Bug 161752 - Make the HeapVerifier useful again
Summary: Make the HeapVerifier useful again
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on: 169443
Blocks:
  Show dependency treegraph
 
Reported: 2016-09-08 13:14 PDT by Filip Pizlo
Modified: 2017-03-15 12:04 PDT (History)
6 users (show)

See Also:


Attachments
work in progress: has lots of debugging code that needs to be cleaned up. (73.64 KB, patch)
2017-02-16 14:54 PST, Mark Lam
no flags Details | Formatted Diff | Diff
work in progress 2 (79.92 KB, patch)
2017-02-17 09:28 PST, Mark Lam
no flags Details | Formatted Diff | Diff
proposed patch. (36.45 KB, patch)
2017-03-10 15:00 PST, Mark Lam
fpizlo: review+
Details | Formatted Diff | Diff
patch for landing. (36.64 KB, patch)
2017-03-13 14:10 PDT, Mark Lam
no flags Details | Formatted Diff | Diff
patch for landing: rebased to ToT again. (36.64 KB, patch)
2017-03-13 14:18 PDT, Mark Lam
no flags Details | Formatted Diff | Diff
Patch for landing: with fix for the Windows build. (36.64 KB, patch)
2017-03-13 16:38 PDT, Mark Lam
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-09-08 13:14:54 PDT
...
Comment 1 Mark Lam 2017-02-16 14:54:50 PST
Created attachment 301831 [details]
work in progress: has lots of debugging code that needs to be cleaned up.
Comment 2 Filip Pizlo 2017-02-16 14:57:30 PST
Comment on attachment 301831 [details]
work in progress: has lots of debugging code that needs to be cleaned up.

View in context: https://bugs.webkit.org/attachment.cgi?id=301831&action=review

> Source/JavaScriptCore/heap/MarkedBlockInlines.h:222
> +                if (vm.heap.verifier())
> +                    vm.heap.verifier()->addSweptCell(cell);
> +            }

This doesn't catch all cases of swept cells.
Comment 3 Mark Lam 2017-02-17 09:28:43 PST
Created attachment 301943 [details]
work in progress 2
Comment 4 Mark Lam 2017-03-10 15:00:37 PST
Created attachment 304082 [details]
proposed patch.

Let's try this on the EWS first.
Comment 5 Filip Pizlo 2017-03-13 10:50:33 PDT
Comment on attachment 304082 [details]
proposed patch.

LGTM.  Seems like you might have builds to fix.
Comment 6 Mark Lam 2017-03-13 14:10:58 PDT
Created attachment 304298 [details]
patch for landing.

Thanks for the review.
Comment 7 Mark Lam 2017-03-13 14:18:23 PDT
Created attachment 304300 [details]
patch for landing: rebased to ToT again.
Comment 8 Mark Lam 2017-03-13 16:38:27 PDT
Created attachment 304322 [details]
Patch for landing: with fix for the Windows build.

The Windows EWS actually found a bug (now fixed).
Comment 9 Mark Lam 2017-03-13 17:40:02 PDT
Landed in r213883: <http://trac.webkit.org/r213883>.
Comment 10 Mark Lam 2017-03-15 12:03:52 PDT
<rdar://problem/30358206>