Bug 161751 – Heap version should be 32-bit

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

Patch forthcoming.

[Filip Pizlo]

Created attachment 288308 [details]
the patch

[WebKit Commit Bot]

Attachment 288308 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/heap/MarkedSpace.h:68:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:465:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/heap/ConservativeRoots.h:54:  The parameter name "heapVersion" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/heap/CellContainer.h:76:  The parameter name "heapVersion" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/heap/MarkedBlock.h:189:  The parameter name "heapVersion" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/heap/MarkedBlock.h:190:  The parameter name "heapVersion" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/heap/MarkedBlock.h:269:  The parameter name "heapVersion" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/heap/MarkedBlock.h:270:  The parameter name "heapVersion" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 8 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Mark Lam]

Comment on attachment 288308 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=288308&action=review

r=me.  Please fix the fixable style issues that the style checker complained about.

> Source/JavaScriptCore/heap/MarkedBlock.h:323
> +        

Please remove leading empty space characters.

[Filip Pizlo]

(In reply to comment #3)
> Comment on attachment 288308 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=288308&action=review
> 
> r=me.  Please fix the fixable style issues that the style checker complained
> about.

OK

> 
> > Source/JavaScriptCore/heap/MarkedBlock.h:323
> > +        
> 
> Please remove leading empty space characters.

OK!  Thanks for the review!

[Filip Pizlo]

Landed in https://trac.webkit.org/changeset/205658

[Geoffrey Garen]

Comment on attachment 288308 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=288308&action=review

> Source/JavaScriptCore/heap/MarkedSpace.h:68
> +    static const HeapVersion initialVersion = 42;  // This can be any value, including random garbage, so long as it's consistent for the lifetime of the process.

It's an interesting tidbit that any value can work, but I'm not sure it's necessary or desirable to take advantage. 0 is the best value to delay flipping for as long as possible, and it is also the least comment-worthy.

[Filip Pizlo]

(In reply to comment #6)
> Comment on attachment 288308 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=288308&action=review
> 
> > Source/JavaScriptCore/heap/MarkedSpace.h:68
> > +    static const HeapVersion initialVersion = 42;  // This can be any value, including random garbage, so long as it's consistent for the lifetime of the process.
> 
> It's an interesting tidbit that any value can work, but I'm not sure it's
> necessary or desirable to take advantage. 0 is the best value to delay
> flipping for as long as possible, and it is also the least comment-worthy.

Wrap-around is not at zero. It's at the initial value. Therefore wrap-around happens after 2^32 flips, regardless of the initial value. 

That's sort of surprising, and I thought it deserved the comment. It's interesting that the comment fails to call out that it can be any value for not just correctness but performance, too.