Bug 161733 – Regression(r186020): Null dereference in getStartDate()

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

There exists a null dereference in WebKit when the following DOM code is executed:

document.createElement("AUDIO").getStartDate()


This bug is present in the latest versions of WebKit Nightly Build.

[Chris Dumez]

Created attachment 288281 [details]
WIP patch

[Build Bot]

Comment on attachment 288281 [details]
WIP patch

Attachment 288281 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2035650

New failing tests:
imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/text.html
imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/hidden.html

[Build Bot]

Created attachment 288296 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 288281 [details]
WIP patch

Attachment 288281 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2035664

New failing tests:
imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/text.html
imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/hidden.html

[Build Bot]

Created attachment 288298 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 288281 [details]
WIP patch

Attachment 288281 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2035643

New failing tests:
fast/forms/week/input-valueasdate-week.html
fast/forms/datetimelocal/input-valueasdate-datetimelocal.html
fast/forms/month/input-valueasdate-month.html
fast/forms/time/time-valueasdate.html
fast/forms/month/input-valueasdate.html
imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/hidden.html
fast/forms/date/input-valueasdate-date.html
imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/text.html

[Build Bot]

Created attachment 288300 [details]
Archive of layout-test-results from ews126 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.5

[Chris Dumez]

Created attachment 288303 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 288303 [details]
Patch

Clearing flags on attachment: 288303

Committed r205744: <http://trac.webkit.org/changeset/205744>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

I suggest we move to Optional<double> for nullable date types, and get rid of the special handling for NaN.

[Chris Dumez]

(In reply to comment #11)
> I suggest we move to Optional<double> for nullable date types, and get rid
> of the special handling for NaN.

Yes, I agree but I did not want to make the change in the same patch. Another issue is that Date was dropped from WebIDL. The specs are now using object type instead and it is update to the implementation to return a Date object. The thing is that I know we do not like to use JS types in our DOM implementation. I asked Sam what he thought about dropping Date support in the bindings generator and update the implementation to return Date object instead of double values but he did not come back to me on this matter yet. Let me know if you have an opinion on this.

[Ross Kirsling]

*** Bug 161898 has been marked as a duplicate of this bug. ***