...
Created attachment 292246 [details] Patch
Comment on attachment 292246 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292246&action=review > Source/JavaScriptCore/wasm/WASMB3IRGenerator.cpp:219 > + // m_unlinkedCalls is a mapping from a function's index to a list of callsites that need to be linked. I changed this to: // m_unlikedCalls is list of each call site and the function index whose address it should be patched with.
Comment on attachment 292246 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292246&action=review r=me > Source/JavaScriptCore/ChangeLog:11 > + have been compiled by the time current function has started compilation we don't know what How about ... by the time *the* current function ...? > Source/JavaScriptCore/ChangeLog:12 > + address we need to call to. For each callsite in the compiling function WASM remembers what Comma after "function"? > Source/JavaScriptCore/ChangeLog:14 > + each functions callsites are linked to the appropriate entrypoint. Hoe about '... *is* linked ...'?
Created attachment 292307 [details] Patch
Comment on attachment 292307 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292307&action=review Looks sensible. > Source/JavaScriptCore/wasm/WASMCallingConvention.h:53 > + : m_gpRegisterArguments(gpRegisterArguments) > + , m_fpRegisterArguments(fpRegisterArguments) I think we would normally say m_gprArgs and m_fprArgs. > Source/JavaScriptCore/wasm/WASMCallingConvention.h:59 > + B3::ValueRep marshallArgumentImpl(Vector<Reg> registerArguments, B3::Type type, size_t& count, size_t& stackOffset) const regArgs
Committed r207671: <http://trac.webkit.org/changeset/207671>