Bug 161712 – Web Inspector: Stepping to a line with an autoContinue breakpoint should still pause

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Summary:
Stepping to a line with an autoContinue breakpoint should still pause

Test:
1. <script>
2. console.log('a');
3. console.log('b');
4. console.log('c');
5. </script>

Steps to Reproduce:
1. Inspect test
2. Set a breakpoint on line 2
3. Set a breakpoint on line 3, add an action, enable autocontinue
4. Reload
  => Pause on line 2
4. Step over
  => Expected to be paused on line 3, instead it ran through everything.

Notes:
- Debugger::pauseIfNeeded does a return if we hit a breakpoint that was auto continue. It should not return if we always paused because of stepping

[Radar WebKit Bug Importer]

<rdar://problem/28193970>

[Joseph Pecoraro]

Created attachment 288245 [details]
[PATCH] Proposed Fix

[Build Bot]

Comment on attachment 288245 [details]
[PATCH] Proposed Fix

Attachment 288245 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2031316

New failing tests:
inspector/debugger/stepping-through-autoContinue-breakpoint.html

[Build Bot]

Created attachment 288247 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 288245 [details]
[PATCH] Proposed Fix

Attachment 288245 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2031424

New failing tests:
inspector/debugger/stepping-through-autoContinue-breakpoint.html

[Build Bot]

Created attachment 288249 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 288245 [details]
[PATCH] Proposed Fix

Attachment 288245 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2031421

New failing tests:
inspector/debugger/stepping-through-autoContinue-breakpoint.html

[Build Bot]

Created attachment 288252 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Joseph Pecoraro]

I'm 90% sure these tests are failing because of other patches still up for review...

[Blaze Burg]

Comment on attachment 288245 [details]
[PATCH] Proposed Fix

r=me

[Joseph Pecoraro]

I'm going to obsolete the reviewed patch. I totally revamped all the stepping code and stepping tests, so I'll put up a new patch with a better test.

[Joseph Pecoraro]

Comment on attachment 288245 [details]
[PATCH] Proposed Fix

Unobsoleting this. The patch stayed the same just the test case changed. So I'll land this with Brian's original review.

[Joseph Pecoraro]

Created attachment 290411 [details]
[PATCH] For Landing (With New Test)

[Joseph Pecoraro]

<https://trac.webkit.org/changeset/206698>