Bug 161711 - URLParser should handle URLs with empty authority
Summary: URLParser should handle URLs with empty authority
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-07 13:28 PDT by Alex Christensen
Modified: 2016-09-08 15:17 PDT (History)
0 users

See Also:


Attachments
Patch (6.75 KB, patch)
2016-09-07 13:29 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (7.04 KB, patch)
2016-09-07 18:48 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (7.10 KB, patch)
2016-09-08 10:30 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (7.04 KB, patch)
2016-09-08 11:31 PDT, Alex Christensen
beidson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-09-07 13:28:05 PDT
URLParser should handle URLs with empty authority
Comment 1 Alex Christensen 2016-09-07 13:29:53 PDT
Created attachment 288180 [details]
Patch
Comment 2 Alex Christensen 2016-09-07 18:48:56 PDT
Created attachment 288221 [details]
Patch
Comment 3 Alex Christensen 2016-09-08 10:30:53 PDT
Created attachment 288275 [details]
Patch
Comment 4 Alex Christensen 2016-09-08 11:31:41 PDT
Created attachment 288290 [details]
Patch
Comment 5 Alex Christensen 2016-09-08 11:33:00 PDT
Comment on attachment 288290 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=288290&action=review

> Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp:371
> -        {"https", "", "", "", 0, "", "", "", "https://"},
> +        {"", "", "", "", 0, "", "", "", ""},

Note: This changes to match the standard and Anne's comment in https://bugs.webkit.org/show_bug.cgi?id=161364
I was skeptical in that patch, but this patch helps me to see he's right.
Comment 6 Brady Eidson 2016-09-08 15:13:30 PDT
Comment on attachment 288290 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=288290&action=review

> Source/WebCore/platform/URLParser.cpp:975
>  void URLParser::parseAuthority(StringView::CodePoints::Iterator& iterator, const StringView::CodePoints::Iterator& end)

This has already come up before, but this method signature stinks :(
Comment 7 Alex Christensen 2016-09-08 15:17:14 PDT
r205667