Bug 161694 - Crash in com.apple.WebCore: WebCore::NavigatorGamepad::gamepadFromPlatformGamepad + 16
Summary: Crash in com.apple.WebCore: WebCore::NavigatorGamepad::gamepadFromPlatformGam...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-09-07 09:38 PDT by Ryan Haddad
Modified: 2016-09-12 11:20 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.74 KB, patch)
2016-09-12 10:52 PDT, Brady Eidson 		achristensen: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2016-09-07 09:38:01 PDT 
LayoutTest gamepad/gamepad-timestamp.html is a flaky crash under GuardMalloc

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.apple.WebCore             	0x00000001125121b0 WebCore::NavigatorGamepad::gamepadFromPlatformGamepad(WebCore::PlatformGamepad&) + 16
1   com.apple.WebCore             	0x0000000111ee8acf WebCore::GamepadManager::makeGamepadVisible(WebCore::PlatformGamepad&, WTF::HashSet<WebCore::NavigatorGamepad*, WTF::PtrHash<WebCore::NavigatorGamepad*>, WTF::HashTraits<WebCore::NavigatorGamepad*> >&, WTF::HashSet<WebCore::DOMWindow*, WTF::PtrHash<WebCore::DOMWindow*>, WTF::HashTraits<WebCore::DOMWindow*> >&) + 495
2   com.apple.WebCore             	0x0000000111ee9071 WebCore::GamepadManager::platformGamepadInputActivity() + 97
3   com.apple.WebKit              	0x00000001069e82da WebKit::WebGamepadProvider::gamepadActivity(WTF::Vector<WebKit::GamepadData, 0ul, WTF::CrashOnOverflow, 16ul> const&) + 160
4   com.apple.WebKit              	0x0000000106a245b6 void IPC::handleMessage<Messages::WebPage::GamepadActivity, WebKit::WebPage, void (WebKit::WebPage::*)(WTF::Vector<WebKit::GamepadData, 0ul, WTF::CrashOnOverflow, 16ul> const&)>(IPC::Decoder&, WebKit::WebPage*, void (WebKit::WebPage::*)(WTF::Vector<WebKit::GamepadData, 0ul, WTF::CrashOnOverflow, 16ul> const&)) + 69
5   com.apple.WebKit              	0x0000000106902411 IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) + 129
6   com.apple.WebKit              	0x0000000106a734a0 WebKit::WebProcess::didReceiveMessage(IPC::Connection&, IPC::Decoder&) + 28
7   com.apple.WebKit              	0x00000001068cedfd IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) + 119
8   com.apple.WebKit              	0x00000001068d195b IPC::Connection::dispatchOneMessage() + 175
9   com.apple.JavaScriptCore      	0x000000011160d7e9 WTF::RunLoop::performWork() + 169
10  com.apple.JavaScriptCore      	0x000000011160da02 WTF::RunLoop::performWork(void*) + 34
11  com.apple.CoreFoundation      	0x0000000107551581 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
12  com.apple.CoreFoundation      	0x000000010753298c __CFRunLoopDoSources0 + 556
13  com.apple.CoreFoundation      	0x0000000107531e76 __CFRunLoopRun + 934
14  com.apple.CoreFoundation      	0x0000000107531874 CFRunLoopRunSpecific + 420
15  com.apple.HIToolbox           	0x000000010940739c RunCurrentEventLoopInMode + 240
16  com.apple.HIToolbox           	0x00000001094071d1 ReceiveNextEventCommon + 432
17  com.apple.HIToolbox           	0x0000000109407006 _BlockUntilNextEventMatchingListInModeWithFilter + 71
18  com.apple.AppKit              	0x0000000104a5ebf1 _DPSNextEvent + 1093
19  com.apple.AppKit              	0x00000001051c2f88 -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 1774
20  com.apple.AppKit              	0x0000000104a53591 -[NSApplication run] + 926
21  com.apple.AppKit              	0x0000000104a1de86 NSApplicationMain + 1237
22  libxpc.dylib                  	0x000000010c01a8b3 _xpc_objc_main + 775
23  libxpc.dylib                  	0x000000010c0192d0 xpc_main + 494
24  com.apple.WebKit.WebContent   	0x0000000104a017a2 0x104a00000 + 6050
25  libdyld.dylib                 	0x000000010bc42255 start + 1
Comment 1 Ryan Haddad 2016-09-07 09:38:31 PDT 
<rdar://problem/28018073>
Comment 2 Brady Eidson 2016-09-12 10:52:08 PDT 
Created attachment 288584 [details]
Patch
Comment 3 Brady Eidson 2016-09-12 11:20:29 PDT 
https://trac.webkit.org/changeset/205814