Bug 161679 - Add StringView constructor from StringView::CodePoints::Iterators
Summary: Add StringView constructor from StringView::CodePoints::Iterators
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-07 00:13 PDT by Alex Christensen
Modified: 2016-09-23 11:08 PDT (History)
6 users (show)

See Also:

Attachments
Patch (5.40 KB, patch)
2016-09-07 00:14 PDT, Alex Christensen 		achristensen: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-09-07 00:13:44 PDT 
Add StringView constructor from StringView::CodePoints::Iterators
Comment 1 Alex Christensen 2016-09-07 00:14:49 PDT 
Created attachment 288114 [details]
Patch
Comment 2 Alex Christensen 2016-09-07 00:17:11 PDT 
This is probably incomplete and needs more testing.  It's complicated enough, though, that I think it might not be worth all these branches and things just to make parameters of a probably-inlined function fit in registers.
Comment 3 Alex Christensen 2016-09-23 11:08:42 PDT 
This is too complicated and shouldn't be done.