Bug 161672 – [INTL] some valid language tags cause errors in Intl constructors

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Andy VanWagoner]

The tests for language tag handling in the kangax compat tables[1][2] fail in JSC on some valid language tags:

cmn-hans-cn-t-ca-u-ca-x-t-u
aa-a-foo-x-a-foo-bar
x-en-u-foo
x-en-u-foo-u-bar

Implementations in Firefox, Chrome, and Edge pass these tests.

[1] http://kangax.github.io/compat-table/esintl/
[2] https://github.com/tc39/test262/blob/83b07ff15eadb141c3d6f4d236a8733b720041d2/test/intl402/6.2.2_a.js

[Andy VanWagoner]

I know where the problem is, and can submit a patch for this.

[Andy VanWagoner]

Created attachment 288135 [details]
Patch

[Mark Lam]

Comment on attachment 288135 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=288135&action=review

r=me

> Source/JavaScriptCore/ChangeLog:8
> +        Fix private use tag parsing to match spec, allowing single character parts.

If it's handy, I suggest quoting the relevant part of the spec here, or providing a url to it.

[Andy VanWagoner]

Created attachment 288154 [details]
Patch

[Andy VanWagoner]

(In reply to comment #3)
> Comment on attachment 288135 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=288135&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/ChangeLog:8
> > +        Fix private use tag parsing to match spec, allowing single character parts.
> 
> If it's handy, I suggest quoting the relevant part of the spec here, or
> providing a url to it.

done. Is this format ok?

[Mark Lam]

Comment on attachment 288154 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 288154 [details]
Patch

Clearing flags on attachment: 288154

Committed r205568: <http://trac.webkit.org/changeset/205568>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.