Bug 161668 - REGRESSION(r205521): broke API tests (Requested by alexchristensen on #webkit).
Summary: REGRESSION(r205521): broke API tests (Requested by alexchristensen on #webkit).
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Commit Bot
URL:
Keywords:
Depends on:
Blocks: 161655 161657 161667
  Show dependency tree / graph
 
Reported: 2016-09-06 18:41 PDT by WebKit Commit Bot
Modified: 2016-09-08 10:25 PDT (History)
3 users (show)

See Also:

Attachments
ROLLOUT of r205521 (10.61 KB, patch)
2016-09-06 18:41 PDT, WebKit Commit Bot 		no flags Details | Formatted Diff | Diff
Patch (10.12 KB, patch)
2016-09-07 17:30 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Commit Bot 2016-09-06 18:41:15 PDT 
http://trac.webkit.org/changeset/205521 broke the build:
broke API tests (Requested by alexchristensen on #webkit).

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 WebKit Commit Bot 2016-09-06 18:41:53 PDT 
Created attachment 288082 [details]
ROLLOUT of r205521

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 WebKit Commit Bot 2016-09-06 18:45:10 PDT 
Comment on attachment 288082 [details]
ROLLOUT of r205521

Clearing flags on attachment: 288082

Committed r205533: <http://trac.webkit.org/changeset/205533>
Comment 3 WebKit Commit Bot 2016-09-06 18:45:13 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Alex Christensen 2016-09-07 17:30:33 PDT 
Reopening to attach new patch.
Comment 5 Alex Christensen 2016-09-07 17:30:34 PDT 
Created attachment 288211 [details]
Patch
Comment 6 Alex Christensen 2016-09-07 18:36:47 PDT 
http://trac.webkit.org/changeset/205580
Comment 7 Alex Christensen 2016-09-07 21:13:59 PDT 
http://trac.webkit.org/changeset/205582 covers up a bug that I can only reproduce on the bots (bot190) but there's something fishy going on.  It's only when there are no logging calls in URLParser.  Maybe using uninitialized memory somewhere.
Comment 8 Ryan Haddad 2016-09-07 22:47:02 PDT 
(In reply to comment #7)
> http://trac.webkit.org/changeset/205582 covers up a bug that I can only
> reproduce on the bots (bot190) but there's something fishy going on.  It's
> only when there are no logging calls in URLParser.  Maybe using
> uninitialized memory somewhere.

The tests still seem to be failing on the bots with this change

https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK1%20%28Tests%29/builds/9549/steps/run-api-tests/logs/stdio
https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/builds/9263
Comment 9 Alex Christensen 2016-09-07 23:02:14 PDT 
Rolled everything out again in r205584
Comment 10 Alex Christensen 2016-09-08 10:25:59 PDT 
Aaaaaaand back in in http://trac.webkit.org/changeset/205650