Bug 161665 - Rename Key to CryptoKey
Summary: Rename Key to CryptoKey
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on:
Blocks: 160877
  Show dependency treegraph
 
Reported: 2016-09-06 17:59 PDT by Jiewen Tan
Modified: 2016-09-09 11:40 PDT (History)
9 users (show)

See Also:


Attachments
Patch (16.31 KB, patch)
2016-09-06 18:09 PDT, Jiewen Tan
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (1.35 MB, application/zip)
2016-09-06 18:55 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews117 for mac-yosemite (1.49 MB, application/zip)
2016-09-06 19:09 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews100 for mac-yosemite (985.50 KB, application/zip)
2016-09-06 19:15 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews125 for ios-simulator-elcapitan-wk2 (7.85 MB, application/zip)
2016-09-06 19:20 PDT, Build Bot
no flags Details
Patch (21.75 KB, patch)
2016-09-08 11:14 PDT, Jiewen Tan
no flags Details | Formatted Diff | Diff
Patch (21.83 KB, patch)
2016-09-08 13:54 PDT, Jiewen Tan
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (1.02 MB, application/zip)
2016-09-08 14:56 PDT, Build Bot
no flags Details
Patch (23.41 KB, patch)
2016-09-08 16:52 PDT, Jiewen Tan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2016-09-06 17:59:31 PDT
Rename Key to CryptoKey.
Comment 1 Jiewen Tan 2016-09-06 18:00:04 PDT
<rdar://problem/28083391>
Comment 2 Jiewen Tan 2016-09-06 18:09:59 PDT
Created attachment 288080 [details]
Patch
Comment 3 Build Bot 2016-09-06 18:55:08 PDT
Comment on attachment 288080 [details]
Patch

Attachment 288080 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2021146

New failing tests:
imported/w3c/WebCryptoAPI/idlharness.html
js/dom/global-constructors-attributes.html
Comment 4 Build Bot 2016-09-06 18:55:12 PDT
Created attachment 288083 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 5 Build Bot 2016-09-06 19:09:39 PDT
Comment on attachment 288080 [details]
Patch

Attachment 288080 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2021183

New failing tests:
imported/w3c/WebCryptoAPI/idlharness.html
Comment 6 Build Bot 2016-09-06 19:09:44 PDT
Created attachment 288087 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 7 Build Bot 2016-09-06 19:14:59 PDT
Comment on attachment 288080 [details]
Patch

Attachment 288080 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2021232

New failing tests:
imported/w3c/WebCryptoAPI/idlharness.html
Comment 8 Build Bot 2016-09-06 19:15:04 PDT
Created attachment 288088 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 9 Chris Dumez 2016-09-06 19:16:47 PDT
Comment on attachment 288080 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=288080&action=review

> Source/WebCore/ChangeLog:8
> +

Please provide a link to the spec for CryptoKey.
Comment 10 Build Bot 2016-09-06 19:20:18 PDT
Comment on attachment 288080 [details]
Patch

Attachment 288080 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2021195

New failing tests:
imported/w3c/WebCryptoAPI/idlharness.html
Comment 11 Build Bot 2016-09-06 19:20:23 PDT
Created attachment 288089 [details]
Archive of layout-test-results from ews125 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.5
Comment 12 Jiewen Tan 2016-09-08 11:14:16 PDT
Created attachment 288285 [details]
Patch
Comment 13 Jiewen Tan 2016-09-08 13:54:12 PDT
Created attachment 288316 [details]
Patch
Comment 14 Build Bot 2016-09-08 14:56:51 PDT
Comment on attachment 288316 [details]
Patch

Attachment 288316 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2036514

New failing tests:
js/dom/global-constructors-attributes.html
Comment 15 Build Bot 2016-09-08 14:56:56 PDT
Created attachment 288331 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 16 Jiewen Tan 2016-09-08 16:52:34 PDT
Created attachment 288359 [details]
Patch
Comment 17 Brent Fulgham 2016-09-08 18:30:31 PDT
Comment on attachment 288359 [details]
Patch

r=me
Comment 18 Chris Dumez 2016-09-08 18:34:03 PDT
Comment on attachment 288359 [details]
Patch

lgtm2
Comment 19 WebKit Commit Bot 2016-09-09 11:40:49 PDT
Comment on attachment 288359 [details]
Patch

Clearing flags on attachment: 288359

Committed r205755: <http://trac.webkit.org/changeset/205755>
Comment 20 WebKit Commit Bot 2016-09-09 11:40:55 PDT
All reviewed patches have been landed.  Closing bug.