Bug 161664 – Support new emoji group candidates

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

Support new emoji group candidates

[Myles C. Maxfield]

Created attachment 288076 [details]
WIP

[Myles C. Maxfield]

Created attachment 288096 [details]
WIP

[Myles C. Maxfield]

Created attachment 288100 [details]
WIP

[Myles C. Maxfield]

Created attachment 288197 [details]
Patch

[Build Bot]

Comment on attachment 288197 [details]
Patch

Attachment 288197 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2029485

New failing tests:
editing/deleting/delete-emoji.html

[Build Bot]

Created attachment 288215 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 288197 [details]
Patch

Attachment 288197 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2029526

New failing tests:
editing/deleting/delete-emoji.html

[Build Bot]

Created attachment 288216 [details]
Archive of layout-test-results from ews124 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.5

[Build Bot]

Comment on attachment 288197 [details]
Patch

Attachment 288197 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2029578

New failing tests:
editing/deleting/delete-emoji.html

[Build Bot]

Created attachment 288219 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 288197 [details]
Patch

Attachment 288197 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2029659

New failing tests:
editing/deleting/delete-emoji.html

[Build Bot]

Created attachment 288220 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Myles C. Maxfield]

Created attachment 288222 [details]
Patch

[Build Bot]

Comment on attachment 288222 [details]
Patch

Attachment 288222 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2030069

New failing tests:
editing/deleting/delete-emoji.html

[Build Bot]

Created attachment 288229 [details]
Archive of layout-test-results from ews124 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.5

[Myles C. Maxfield]

Created attachment 288277 [details]
Patch

[Jon Lee]

Comment on attachment 288277 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=288277&action=review

> Source/WebCore/platform/text/CharacterProperties.h:61
> +        || (character >= 0x1F574 && character == 0x1F575)

Bad second comparison.
(character >= 0x1F574 && character <= 0x1F575)

[Myles C. Maxfield]

Created attachment 288294 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 288294 [details]
Patch

Clearing flags on attachment: 288294

Committed r205657: <http://trac.webkit.org/changeset/205657>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.