Bug 161656 – Web Inspector: step-into `console.log(o)` should not step through inspector javascript

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Summary:
step-into `console.log(o)` should not step through inspector javascript

Test:
1. <script>
2. console.log(window);
3. <script>

Steps to Reproduce:
1. Inspect test case
2. Set a breakpoint on line 2
3. Reload
  => Pauses on line 2
4. Step-in
  => Expected to step over the console.log statement, instead stayed on the line (20+ times)

Notes:
- Engineering builds can runtime toggle a debug UI to see and step through InjectedScriptSource
  - Maybe this requires a separate backend command to enable/disable this?

[Radar WebKit Bug Importer]

<rdar://problem/28181123>

[Blaze Burg]

This seems like a special case of script black boxing.

[Joseph Pecoraro]

Created attachment 291409 [details]
[PATCH] Proposed Fix

[Build Bot]

Comment on attachment 291409 [details]
[PATCH] Proposed Fix

Attachment 291409 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2273212

New failing tests:
inspector/debugger/breakpoint-syntax-error-top-level.html
inspector/debugger/setPauseOnExceptions-uncaught.html
inspector/debugger/command-line-api-exception.html
inspector/dom-debugger/node-removed.html
inspector/debugger/regress-133182.html
inspector/debugger/setPauseOnExceptions-all.html

[Build Bot]

Created attachment 291414 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Joseph Pecoraro]

Investigating test failures.

[Joseph Pecoraro]

(In reply to comment #6)
> Investigating test failures.

The issue is that SourceID could be 0, and the default HashSet doesn't allow 0. I'm making the following change to allow Map/Set with a SourceID of 0:

-    HashMap<SourceID, DebuggerParseData> m_parseDataMap;
-    HashSet<SourceID> m_blacklistedScripts;
+    HashMap<SourceID, DebuggerParseData, WTF::IntHash<SourceID>, WTF::UnsignedWithZeroKeyHashTraits<SourceID>> m_parseDataMap;
+    HashSet<SourceID, WTF::IntHash<SourceID>, WTF::UnsignedWithZeroKeyHashTraits<SourceID>> m_blacklistedScripts;

[Build Bot]

Comment on attachment 291409 [details]
[PATCH] Proposed Fix

Attachment 291409 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2273307

New failing tests:
inspector/debugger/breakpoint-syntax-error-top-level.html
inspector/debugger/setPauseOnExceptions-uncaught.html
inspector/debugger/command-line-api-exception.html
inspector/dom-debugger/node-removed.html
inspector/debugger/regress-133182.html
inspector/debugger/setPauseOnExceptions-all.html

[Build Bot]

Created attachment 291421 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Joseph Pecoraro]

Created attachment 291423 [details]
[PATCH] For Landing

[Joseph Pecoraro]

Comment on attachment 291423 [details]
[PATCH] For Landing

View in context: https://bugs.webkit.org/attachment.cgi?id=291423&action=review

> Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.h:161
> +    HashSet<JSC::SourceID> m_blacklistedScripts;

Err, this should be removed.

[Joseph Pecoraro]

Created attachment 291426 [details]
[PATCH] For Landing

[Build Bot]

Comment on attachment 291409 [details]
[PATCH] Proposed Fix

Attachment 291409 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2273308

New failing tests:
inspector/debugger/breakpoint-syntax-error-top-level.html
inspector/debugger/pause-reason.html
inspector/debugger/setPauseOnExceptions-uncaught.html
inspector/debugger/command-line-api-exception.html
inspector/dom-debugger/node-removed.html
inspector/debugger/pause-on-assert.html
inspector/debugger/csp-exceptions.html
inspector/debugger/regress-133182.html
inspector/debugger/setPauseOnExceptions-all.html

[Build Bot]

Created attachment 291428 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[WebKit Commit Bot]

Comment on attachment 291426 [details]
[PATCH] For Landing

Clearing flags on attachment: 291426

Committed r207267: <http://trac.webkit.org/changeset/207267>