RESOLVED FIXED 161648
Web Inspector: Avoid linkifying some schemes in console logs 
https://bugs.webkit.org/show_bug.cgi?id=161648
Summary Web Inspector: Avoid linkifying some schemes in console logs
Joseph Pecoraro
Reported 2016-09-06 15:22:13 PDT
Summary: Avoid linkifying some schemes in console logs. Steps to Reproduce: 1. Inspect this page 2. js> console.log("javascript://alert(1)") => This becomes a link. This is not useful inside Web Inspector Notes: - Even if a javascript: link is clicked, we should make sure it doesn't do anything.
Attachments
[PATCH] Proposed Fix (2.81 KB, patch)
2016-09-06 15:23 PDT, Joseph Pecoraro 		bburg: review+
bburg: commit-queue-
DetailsFormatted DiffDiff
[PATCH] For Landing (2.80 KB, patch)
2016-09-06 17:02 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2016-09-06 15:22:27 PDT
<rdar://problem/16413270>
Joseph Pecoraro
Comment 2 2016-09-06 15:23:37 PDT
Created attachment 288053 [details] [PATCH] Proposed Fix
Blaze Burg
Comment 3 2016-09-06 15:41:37 PDT
Comment on attachment 288053 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=288053&action=review r=me (please fix typo) > Source/WebInspectorUI/UserInterface/Base/Main.js:2233 > + if (linkString.startsWith("data:") || linkString.startsWith("javascript:") || linkString.startsWith("mailto")) { This should be mailto:
Joseph Pecoraro
Comment 4 2016-09-06 17:02:59 PDT
Created attachment 288067 [details] [PATCH] For Landing
WebKit Commit Bot
Comment 5 2016-09-06 17:33:54 PDT
Comment on attachment 288067 [details] [PATCH] For Landing Clearing flags on attachment: 288067 Committed r205529: <http://trac.webkit.org/changeset/205529>
Note You need to log in before you can comment on or make changes to this bug.