Bug 161644 – Add support for input.minLength / textArea.minLength

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Add support for input.minLength / textArea.minLength:
- https://html.spec.whatwg.org/#dom-input-minlength
- https://html.spec.whatwg.org/#dom-textarea-minlength

Chrome implements this, Firefox does not yet.

[Chris Dumez]

Created attachment 288046 [details]
Patch

[Chris Dumez]

Created attachment 288048 [details]
Patch

[Chris Dumez]

Created attachment 288054 [details]
Patch

[Darin Adler]

Comment on attachment 288054 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=288054&action=review

> Source/WebCore/html/HTMLInputElement.cpp:297
> +        // Return false for the default value or a value set by a script even if
> +        // it is longer than maxLength.

Comment here mentions maxLength. That must be wrong.

> Source/WebCore/html/HTMLInputElement.h:408
> +    bool tooShort(const String&, NeedsToCheckDirtyFlag) const;

Seems like this should take a StringView, not a String.

[Chris Dumez]

Created attachment 288062 [details]
Patch

[Chris Dumez]

Created attachment 288065 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 288065 [details]
Patch

Clearing flags on attachment: 288065

Committed r205524: <http://trac.webkit.org/changeset/205524>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Chris Rebert]

The "Assigning non-numeric to minlength sets minlength to 0" test in
http://w3c-test.org/html/semantics/forms/the-input-element/minlength.html
is still failing.

[Chris Rebert]

*** Bug 149832 has been marked as a duplicate of this bug. ***

[Chris Dumez]

(In reply to comment #9)
> The "Assigning non-numeric to minlength sets minlength to 0" test in
> http://w3c-test.org/html/semantics/forms/the-input-element/minlength.html
> is still failing.

Thanks for letting me know. I'll fix this soon:
https://bugs.webkit.org/show_bug.cgi?id=162727

[Ryosuke Niwa]

We should also treat CRLF as one character per the recent spec change if we haven't done so.