Bug 161641 - [iOS] Remove soft linking of MobileCoreServices.framework
Summary: [iOS] Remove soft linking of MobileCoreServices.framework
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-09-06 12:57 PDT by David Kilzer (:ddkilzer)
Modified: 2016-09-06 16:03 PDT (History)
7 users (show)

See Also:

Attachments
Patch v1 (15.89 KB, patch)
2016-09-06 13:45 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2016-09-06 12:57:00 PDT 
Since MobileCoreServices.framework does not depend on WebCore.framework, and there is no longer a penalty for linking frameworks (until a symbol is used), we can get rid of the eight places where MobileCoreServices.framework is soft-linked in WebCore for iOS (one of which isn't even used any longer).
Comment 1 David Kilzer (:ddkilzer) 2016-09-06 12:57:18 PDT 
<rdar://problem/10420118>
Comment 2 David Kilzer (:ddkilzer) 2016-09-06 13:45:06 PDT 
Created attachment 288042 [details]
Patch v1
Comment 3 Darin Adler 2016-09-06 15:59:04 PDT 
Comment on attachment 288042 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=288042&action=review

> Source/WebCore/ChangeLog:9
> +        * Configurations/WebCore.xcconfig: Add hard link to

"hard link" is a term of art that normally means the thing the "ln" command creates

So I would have used different wording here.
Comment 4 WebKit Commit Bot 2016-09-06 16:03:52 PDT 
Comment on attachment 288042 [details]
Patch v1

Clearing flags on attachment: 288042

Committed r205516: <http://trac.webkit.org/changeset/205516>
Comment 5 WebKit Commit Bot 2016-09-06 16:03:56 PDT 
All reviewed patches have been landed.  Closing bug.