Bug 161636 – Align srcset attribute parsing with the HTML specification

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Align srcset attribute parsing with the HTML specification:
- https://html.spec.whatwg.org/#parse-a-srcset-attribute

This is covered by:
http://w3c-test.org/html/semantics/embedded-content/the-img-element/srcset/parse-a-srcset-attribute.html

Firefox and Chrome pass all of these checks. However, WebKit fails 100 out of 236.

[Chris Dumez]

Created attachment 288037 [details]
Patch

[Darin Adler]

Comment on attachment 288037 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=288037&action=review

> Source/WebCore/html/parser/HTMLSrcsetParser.cpp:137
> +            Optional<double> density = parseValidHTMLFloatingPointNumber(descriptor);

auto?

> Source/WebCore/html/parser/HTMLSrcsetParser.cpp:144
> +            Optional<int> resourceWidth = parseValidHTMLNonNegativeInteger(descriptor);

auto?

> Source/WebCore/html/parser/HTMLSrcsetParser.cpp:153
> +            Optional<int> resourceHeight = parseValidHTMLNonNegativeInteger(descriptor);

auto?

[Chris Dumez]

Comment on attachment 288037 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=288037&action=review

>> Source/WebCore/html/parser/HTMLSrcsetParser.cpp:137
>> +            Optional<double> density = parseValidHTMLFloatingPointNumber(descriptor);
> 
> auto?

Optional<> is one of the only cases where I personally prefer not to use auto, for clarity because the !density check below becomes a bit confusing.

[WebKit Commit Bot]

Comment on attachment 288037 [details]
Patch

Clearing flags on attachment: 288037

Committed r205515: <http://trac.webkit.org/changeset/205515>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.