Bug 161621 - [GTK][EFL] Make *_PROCESS_CMD_PREFIX conditional on DEVELOPER_MODE
Summary: [GTK][EFL] Make *_PROCESS_CMD_PREFIX conditional on DEVELOPER_MODE
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-06 03:06 PDT by Emanuele Aina
Modified: 2016-09-06 04:21 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.25 KB, patch)
2016-09-06 03:07 PDT, Emanuele Aina 		no flags Details | Formatted Diff | Diff
Patch (4.27 KB, patch)
2016-09-06 03:39 PDT, Emanuele Aina 		no flags Details | Formatted Diff | Diff
Patch (4.27 KB, patch)
2016-09-06 03:51 PDT, Emanuele Aina 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emanuele Aina 2016-09-06 03:06:55 PDT 
[GTK][EFL] Make *_PROCESS_CMD_PREFIX conditional on DEVELOPER_MODE
Comment 1 Emanuele Aina 2016-09-06 03:07:49 PDT 
Created attachment 288007 [details]
Patch
Comment 2 Emanuele Aina 2016-09-06 03:39:36 PDT 
Created attachment 288010 [details]
Patch
Comment 3 Carlos Garcia Campos 2016-09-06 03:44:05 PDT 
Comment on attachment 288010 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=288010&action=review

> Source/WebKit2/UIProcess/Launcher/ProcessLauncher.h:63
> -#if (PLATFORM(EFL) || PLATFORM(GTK)) && !defined(NDEBUG)
> +#if (PLATFORM(EFL) || PLATFORM(GTK)) && ENABLE(DEVELOPER_MODE)

Now that we are changing this, let's be consistent. Either change the previous one or this one I don't mind.
Comment 4 Emanuele Aina 2016-09-06 03:51:44 PDT 
Created attachment 288013 [details]
Patch
Comment 5 WebKit Commit Bot 2016-09-06 04:21:50 PDT 
Comment on attachment 288013 [details]
Patch

Clearing flags on attachment: 288013

Committed r205474: <http://trac.webkit.org/changeset/205474>
Comment 6 WebKit Commit Bot 2016-09-06 04:21:54 PDT 
All reviewed patches have been landed.  Closing bug.