Bug 161608 - [GTK] Several failing WebViewEditor API tests
Summary: [GTK] Several failing WebViewEditor API tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks: 168219
  Show dependency tree / graph
 
Reported: 2016-09-05 09:35 PDT by Michael Catanzaro
Modified: 2017-02-12 22:42 PST (History)
3 users (show)

See Also:

Attachments
Patch (3.61 KB, patch)
2017-02-12 13:06 PST, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2016-09-05 09:35:51 PDT 
Almost all of the TestWebViewEditor tests have started failing:

TEST: ./Tools/gtk/../../WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestWebViewEditor... (pid=21695)

  /webkit2/WebKitWebView/editable/editable:                            **

ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:79:gchar* EditorTest::cutSelection(): assertion failed: (canExecuteEditingCommand(WEBKIT_EDITING_COMMAND_CUT))

FAIL

GTester: last random seed: R02S5c171cadb5d23ea19dc53f9a9db9f391

(pid=21727)

  /webkit2/WebKitWebView/cut-copy-paste/non-editable:                  **

ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:144:void testWebViewEditorCutCopyPasteNonEditable(EditorTest*, gconstpointer): assertion failed: (test->canExecuteEditingCommand(WEBKIT_EDITING_COMMAND_COPY))

FAIL

GTester: last random seed: R02S438d2f2e7479860f818b6f505f174bfb

(pid=21758)

  /webkit2/WebKitWebView/cut-copy-paste/editable:                      **

ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:171:void testWebViewEditorCutCopyPasteEditable(EditorTest*, gconstpointer): assertion failed: (test->canExecuteEditingCommand(WEBKIT_EDITING_COMMAND_CUT))

FAIL

GTester: last random seed: R02S9452d8e2fc6d821470701eccd664efef

(pid=21789)

  /webkit2/WebKitWebView/select-all/non-editable:                      **

ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:194:void testWebViewEditorSelectAllNonEditable(EditorTest*, gconstpointer): assertion failed (clipboardText.get() == "make Jack a dull"): (NULL == "make Jack a dull")

FAIL

GTester: last random seed: R02S3dc594b867ccb8f2e3ae3a2e15856f36

(pid=21820)

  /webkit2/WebKitWebView/select-all/editable:                          **

ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:222:void testWebViewEditorSelectAllEditable(EditorTest*, gconstpointer): assertion failed (clipboardText.get() == "make Jack a dull"): (NULL == "make Jack a dull")

FAIL

GTester: last random seed: R02S15b54bc3e4058f88cfd510dae39e13f0

(pid=21851)

  /webkit2/WebKitWebView/editor-state/typing-attributes:               OK

  /webkit2/WebKitWebView/insert/image:                                 OK

  /webkit2/WebKitWebView/insert/link:                                  OK

FAIL: ./Tools/gtk/../../WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestWebViewEditor

Tests skipped. Please unskip when fixed.
Comment 1 Michael Catanzaro 2017-02-12 13:06:37 PST 
Created attachment 301316 [details]
Patch
Comment 2 Carlos Garcia Campos 2017-02-12 22:17:05 PST 
Comment on attachment 301316 [details]
Patch

Good catch!
Comment 3 WebKit Commit Bot 2017-02-12 22:42:47 PST 
Comment on attachment 301316 [details]
Patch

Clearing flags on attachment: 301316

Committed r212224: <http://trac.webkit.org/changeset/212224>
Comment 4 WebKit Commit Bot 2017-02-12 22:42:52 PST 
All reviewed patches have been landed.  Closing bug.