Bug 161598 – [Mac] Static Analyzer warnings about unused values in CDMSessionAVStreamSession.mm

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Joseph Pecoraro]

Static Analyzer warnings about unused values in CDMSessionAVStreamSession.mm:

    AnalyzeShallow platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm
    Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:314:9: warning: Value stored to 'systemCode' is never read
            systemCode = '!mor';
            ^            ~~~~~~
    Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:323:9: warning: Value stored to 'systemCode' is never read
            systemCode = '!mor';
            ^            ~~~~~~
    Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:330:5: warning: Value stored to 'systemCode' is never read
        systemCode = 0;
        ^            ~
    3 warnings generated.

Seems that in r195410 this parameter accidentally dropped its reference-ness. Lets add it back.

[Joseph Pecoraro]

Created attachment 287942 [details]
[PATCH] Proposed Fix

Jer, could we write a test for this?

[Darin Adler]

Comment on attachment 287942 [details]
[PATCH] Proposed Fix

Wow, seems like this also fixes a bug, not just a static analyzer warning! I wonder if someone knows how to write a test that would demonstrate the bug.

Also, I would like to remind everyone that in new code we should model multiple return values as return value, perhaps using a combination of structures, tuples, pairs, optionals, and variants as needed, not as one return value and two out arguments.

[Darin Adler]

I see Joe’s question/request to Jer now.

[WebKit Commit Bot]

Comment on attachment 287942 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 287942

Committed r205456: <http://trac.webkit.org/changeset/205456>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.