Bug 161590 – [GTK] Layout test editing/inserting/typing-space-to-trigger-smart-link.html fails

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Michael Catanzaro]

Layout test editing/inserting/typing-space-to-trigger-smart-link.html has been failing since it was unskipped in r205094 ("WTR needs an implementation of setAutomaticLinkDetectionEnabled"):

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/editing/inserting/typing-space-to-trigger-smart-link-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/editing/inserting/typing-space-to-trigger-smart-link-actual.txt
@@ -1,4 +1,4 @@
 The www.foo.com should be underlined and there is an anchor node created for it.
 The www.bar.com should be underlined and there is an anchor node created for it.
-PASS: the anchor for 'www.foo.com' has been created.
-PASS: the anchor for 'www.bar.com' has been created.
+Failed: the expected content was 'The <a href="http://www.foo.com">www.foo.com</a> should be underlined and there is an anchor node created for it.', but the actual result was 'The www.foo.com should be underlined and there is an anchor node created for it.'.
+Failed: the expected content was 'The <a href="http://www.bar.com">www.bar.com</a> should be underlined and there is an anchor node created for it.', but the actual result was 'The www.bar.com should be underlined and there is an anchor node created for it.'.

Obviously the link is missing. Updating expectations accordingly.

[Ryosuke Niwa]

GTK+ port doesn't enable smart space, right?  So I think we just need to skip the test.

[Ryosuke Niwa]

Sorry, I meant to say smart link.

[Jonathan Bedard]

Yes, I was closing this bug and noting so when our comments collided.

This is caused by a failure to call setAuomaticLinkDetection.  However, setAutomaticLinkDetection is an AppKit specific feature.  This test should not run on GTK.

[Michael Catanzaro]

(In reply to comment #3)
> Yes, I was closing this bug and noting so when our comments collided.
> 
> This is caused by a failure to call setAuomaticLinkDetection.  However,
> setAutomaticLinkDetection is an AppKit specific feature.  This test should
> not run on GTK.

Then Ryosuke is right, we need to skip it!

[Jonathan Bedard]

(In reply to comment #4)
> Then Ryosuke is right, we need to skip it!
> ...

https://bugs.webkit.org/show_bug.cgi?id=161919 will have this change shortly, along with skipping this class of test on iOS, EFL and Windows.

[Michael Catanzaro]

(In reply to comment #5)
> (In reply to comment #4)
> > Then Ryosuke is right, we need to skip it!
> > ...
> 
> https://bugs.webkit.org/show_bug.cgi?id=161919 will have this change
> shortly, along with skipping this class of test on iOS, EFL and Windows.

Thanks. Since it's macOS specific, you might skip it in the global test expectations, and add a Pass expectation in the macOS file.