Bug 161582 - WebRTC: Several media stream tests crashing
Summary: WebRTC: Several media stream tests crashing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-04 19:21 PDT by Michael Catanzaro
Modified: 2016-09-05 06:56 PDT (History)
2 users (show)

See Also:


Attachments
patch (3.20 KB, patch)
2016-09-05 06:05 PDT, Philippe Normand
alex: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2016-09-04 19:21:39 PDT
We have several media stream tests crashing with this assertion in OpenWebRTC:

owr_video_renderer.c:314:owr_video_renderer_get_element: assertion failed: (flip)

Each test has been broken since it was added (though some of the tests originally timed out instead of crashed). The affected tests are:

fast/mediastream/apply-constraints-video.html
fast/mediastream/MediaStream-video-element-displays-buffer.html
fast/mediastream/MediaStream-video-element-video-tracks-disabled-then-enabled.html
fast/mediastream/MediaStream-video-element-video-tracks-disabled.html

Example backtrace:

Thread 1 (Thread 0x2b0031e90f80 (LWP 14747)):
#0  0x00002b002aa89067 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
#1  0x00002b002aa8a448 in __GI_abort () at abort.c:89
#2  0x00002b0027d84105 in g_assertion_message () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.44.1/glib/gtestutils.c:2356
#3  0x00002b0027d8418a in g_assertion_message_expr () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.44.1/glib/gtestutils.c:2371
#4  0x00002b00264ef131 in owr_video_renderer_get_element () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/openwebrtc/local/owr_video_renderer.c:314
#5  0x00002b00264ef1fd in owr_video_renderer_constructed () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/openwebrtc/local/owr_video_renderer.c:360
#6  0x00002b0027cd5534 in g_object_new_internal () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.44.1/gobject/gobject.c:1814
#7  0x00002b0027cd70f5 in g_object_new_valist () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.44.1/gobject/gobject.c:2033
#8  0x00002b0027cd7404 in g_object_new () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.44.1/gobject/gobject.c:1617
#9  0x00002b00220428cf in _ZN7WebCore30MediaPlayerPrivateGStreamerOwr15createVideoSinkEv () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#10 0x00002b00220421b5 in _ZN7WebCore30MediaPlayerPrivateGStreamerOwr4loadERNS_18MediaStreamPrivateE () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#11 0x00002b0021b2e4d2 in _ZN7WebCore11MediaPlayer23loadWithNextMediaEngineEPKNS_18MediaPlayerFactoryE () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#12 0x00002b0021b2ef9b in _ZN7WebCore11MediaPlayer4loadEPNS_18MediaStreamPrivateE () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#13 0x00002b00217674b8 in _ZN7WebCore16HTMLMediaElement12loadResourceERKNS_3URLERNS_11ContentTypeERKN3WTF6StringE () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#14 0x00002b0021767e11 in _ZN7WebCore16HTMLMediaElement19selectMediaResourceEv () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#15 0x00002b002176974a in _ZN7WebCore16HTMLMediaElement23pendingActionTimerFiredEv () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#16 0x00002b0021abab5f in _ZN7WebCore12ThreadTimers24sharedTimerFiredInternalEv () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#17 0x00002b002412ec1a in _ZZN3WTF7RunLoop9TimerBaseC4ERS0_ENUlPvE_4_FUNES3_ () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18
#18 0x00002b0027d5eecd in g_main_dispatch () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.44.1/glib/gmain.c:3122
#19 g_main_context_dispatch () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.44.1/glib/gmain.c:3737
#20 0x00002b0027d5f268 in g_main_context_iterate () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.44.1/glib/gmain.c:3808
#21 0x00002b0027d5f582 in g_main_loop_run () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.44.1/glib/gmain.c:4002
#22 0x00002b002412efc0 in _ZN3WTF7RunLoop3runEv () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18
#23 0x00002b002112b7c2 in WebProcessMainUnix () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#24 0x00002b002aa75b45 in __libc_start_main (main=0x400bf0 <main>, argc=2, argv=0x7fff6f6f5bd8, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fff6f6f5bc8) at libc-start.c:287
#25 0x0000000000400c45 in _start ()

Updating expectations accordingly.
Comment 1 Philippe Normand 2016-09-05 01:02:59 PDT
Oops this is my fault, sorry.

With this patch in OpenWebRTC things should improve a bit:

https://github.com/EricssonResearch/openwebrtc/pull/629

I'll try to have it merged upstream and will bump our OpenWebRTC version in JHBuild.
Comment 2 Philippe Normand 2016-09-05 06:05:28 PDT
Created attachment 287947 [details]
patch
Comment 3 Philippe Normand 2016-09-05 06:56:44 PDT
Committed r205451: <http://trac.webkit.org/changeset/205451>