More bindings improvements, particularly things not needed for JavaScript bindings
Created attachment 287891 [details] Patch
Comment on attachment 287891 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=287891&action=review > Source/WebCore/svg/SVGTests.cpp:110 > +// "AnimationEventsAttribute", Why commented out? Also, strange indentation
Comment on attachment 287891 [details] Patch Attachment 287891 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2003990 New failing tests: svg/W3C-SVG-1.1-SE/types-dom-06-f.svg svg/W3C-SVG-1.1/struct-dom-03-b.svg imported/mozilla/svg/dynamic-conditions-12.svg svg/W3C-SVG-1.1/struct-dom-05-b.svg svg/W3C-SVG-1.1/struct-dom-04-b.svg imported/mozilla/svg/dynamic-conditions-08.svg svg/custom/svg-features.html
Created attachment 287892 [details] Archive of layout-test-results from ews100 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 287891 [details] Patch Attachment 287891 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2003988 New failing tests: svg/W3C-SVG-1.1/struct-dom-04-b.svg svg/W3C-SVG-1.1-SE/types-dom-06-f.svg svg/custom/svg-features.html svg/W3C-SVG-1.1/struct-dom-05-b.svg svg/W3C-SVG-1.1/struct-dom-03-b.svg
Created attachment 287893 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 287891 [details] Patch Attachment 287891 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2003987 New failing tests: svg/W3C-SVG-1.1-SE/types-dom-06-f.svg imported/mozilla/svg/dynamic-conditions-12.svg svg/W3C-SVG-1.1/struct-dom-03-b.svg svg/W3C-SVG-1.1/struct-dom-05-b.svg svg/W3C-SVG-1.1/struct-dom-04-b.svg imported/mozilla/svg/dynamic-conditions-08.svg svg/custom/svg-features.html
Created attachment 287894 [details] Archive of layout-test-results from ews117 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 287891 [details] Patch Attachment 287891 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2003995 New failing tests: svg/W3C-SVG-1.1/struct-dom-04-b.svg svg/custom/svg-features.html svg/W3C-SVG-1.1/struct-dom-03-b.svg svg/W3C-SVG-1.1/struct-dom-05-b.svg svg/W3C-SVG-1.1-SE/types-dom-06-f.svg
Created attachment 287895 [details] Archive of layout-test-results from ews124 for ios-simulator-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-elcapitan-wk2 Platform: Mac OS X 10.11.5
Comment on attachment 287891 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=287891&action=review >> Source/WebCore/svg/SVGTests.cpp:110 >> +// "AnimationEventsAttribute", > > Why commented out? Also, strange indentation Same as before. No idea exactly why it’s useful to have this here commented out. All of this code should be deleted once an expert on our SVG support decides it’s not needed. I could sort this list and get rid of the commented out parts if we like that better.
Created attachment 287969 [details] Patch
New version, cleaned up logic a bit and dealt with comment by Alex. And added new expected results for SVG tests as I discussed with Kling. Taking the risk and setting review+ before I know whether the bots are green. Tests now pass locally, though.
Largeness of the patch is because of the pixel test results.
Comment on attachment 287969 [details] Patch Looks like there are a couple more SVG tests affected by the change.
Comment on attachment 287969 [details] Patch Attachment 287969 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2013219 New failing tests: svg/W3C-SVG-1.1-SE/types-dom-06-f.svg imported/mozilla/svg/dynamic-conditions-08.svg imported/mozilla/svg/dynamic-conditions-12.svg
Created attachment 287973 [details] Archive of layout-test-results from ews100 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 287969 [details] Patch Attachment 287969 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2013228 New failing tests: svg/W3C-SVG-1.1-SE/types-dom-06-f.svg
Created attachment 287975 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 287969 [details] Patch Attachment 287969 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2013229 New failing tests: imported/w3c/web-platform-tests/fetch/api/cors/cors-basic-worker.html svg/W3C-SVG-1.1-SE/types-dom-06-f.svg imported/mozilla/svg/dynamic-conditions-08.svg imported/mozilla/svg/dynamic-conditions-12.svg
Created attachment 287976 [details] Archive of layout-test-results from ews117 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 287969 [details] Patch Attachment 287969 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2013233 New failing tests: svg/W3C-SVG-1.1/struct-dom-04-b.svg svg/W3C-SVG-1.1/struct-dom-03-b.svg svg/W3C-SVG-1.1/struct-dom-05-b.svg svg/W3C-SVG-1.1-SE/types-dom-06-f.svg
Created attachment 287977 [details] Archive of layout-test-results from ews125 for ios-simulator-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-elcapitan-wk2 Platform: Mac OS X 10.11.5
Created attachment 287979 [details] Patch
Comment on attachment 287979 [details] Patch Attachment 287979 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2013680 New failing tests: imported/mozilla/svg/dynamic-conditions-08.svg imported/mozilla/svg/dynamic-conditions-12.svg
Created attachment 287983 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 287984 [details] Patch
All tests passing so ready to review.
Comment on attachment 287984 [details] Patch Clearing flags on attachment: 287984 Committed r205468: <http://trac.webkit.org/changeset/205468>
All reviewed patches have been landed. Closing bug.