Bug 161565 - Web Inspector: Address ESLint undefined variable errors in UserInterface/Views
Summary: Web Inspector: Address ESLint undefined variable errors in UserInterface/Views
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2016-09-02 20:16 PDT by Joseph Pecoraro
Modified: 2016-09-03 07:40 PDT (History)
7 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (3.08 KB, patch)
2016-09-02 20:17 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-09-02 20:16:57 PDT 
Address ESLint undefined variable errors in UserInterface/Views:

    Source/WebInspectorUI/UserInterface/Views/DataGrid.js
       873:19  error  'identifier' is defined but never used                no-unused-vars
       875:20  error  'columnIdentifier' is not defined                     no-undef

    Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js
      1018:50  error  'breakpoint' is not defined            no-undef

    Source/WebInspectorUI/UserInterface/Views/TextContentView.js
      154:13  error  'activated' is defined but never used  no-unused-vars
      155:47  error  'formatted' is not defined             no-undef

Real issues that would cause runtime exceptions.
Comment 1 Joseph Pecoraro 2016-09-02 20:17:38 PDT 
Created attachment 287851 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2016-09-03 07:40:33 PDT 
Comment on attachment 287851 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 287851

Committed r205401: <http://trac.webkit.org/changeset/205401>
Comment 3 WebKit Commit Bot 2016-09-03 07:40:36 PDT 
All reviewed patches have been landed.  Closing bug.