Bug 161563 - Web Inspector: Address ESLint undefined variable errors
Summary: Web Inspector: Address ESLint undefined variable errors
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
Keywords: DoNotImportToRadar
Depends on:
Reported: 2016-09-02 19:26 PDT by Joseph Pecoraro
Modified: 2016-09-03 07:42 PDT (History)
7 users (show)

See Also:

[PATCH] Proposed Fix (6.50 KB, patch)
2016-09-02 19:27 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-09-02 19:26:41 PDT
Address ESLint undefined variable errors:

      86:65  error  'origin' is not defined  no-undef

      73:52  error  'source' is not defined  no-undef

      586:169  error  'args' is not defined  no-undef

These are all legit errors. Fortunately there are in handling error conditions that shouldn't be reached!
Comment 1 Joseph Pecoraro 2016-09-02 19:27:20 PDT
Created attachment 287849 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2016-09-02 19:29:10 PDT
Attachment 287849 [details] did not pass style-queue:

ERROR: Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:586:  Line contains single-quote character.  [js/syntax] [5]
Total errors found: 1 in 7 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2016-09-03 07:42:32 PDT
Comment on attachment 287849 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 287849

Committed r205402: <http://trac.webkit.org/changeset/205402>
Comment 4 WebKit Commit Bot 2016-09-03 07:42:35 PDT
All reviewed patches have been landed.  Closing bug.