RESOLVED FIXED 161563
Web Inspector: Address ESLint undefined variable errors 
https://bugs.webkit.org/show_bug.cgi?id=161563
Summary Web Inspector: Address ESLint undefined variable errors
Joseph Pecoraro
Reported 2016-09-02 19:26:41 PDT
Address ESLint undefined variable errors: Source/WebInspectorUI/UserInterface/Controllers/CSSStyleManager.js 86:65 error 'origin' is not defined no-undef Source/WebInspectorUI/UserInterface/Models/IssueMessage.js 73:52 error 'source' is not defined no-undef Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js 586:169 error 'args' is not defined no-undef These are all legit errors. Fortunately there are in handling error conditions that shouldn't be reached!
Attachments
[PATCH] Proposed Fix (6.50 KB, patch)
2016-09-02 19:27 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2016-09-02 19:27:20 PDT
Created attachment 287849 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 2 2016-09-02 19:29:10 PDT
Attachment 287849 [details] did not pass style-queue: ERROR: Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:586: Line contains single-quote character. [js/syntax] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 3 2016-09-03 07:42:32 PDT
Comment on attachment 287849 [details] [PATCH] Proposed Fix Clearing flags on attachment: 287849 Committed r205402: <http://trac.webkit.org/changeset/205402>
WebKit Commit Bot
Comment 4 2016-09-03 07:42:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.