Bug 161562 - Unbreak customElements.whenDefined after r205383 with a crash fix
Summary: Unbreak customElements.whenDefined after r205383 with a crash fix
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks: 154907
  Show dependency tree / graph
 
Reported: 2016-09-02 19:00 PDT by Ryosuke Niwa
Modified: 2016-09-03 16:27 PDT (History)
10 users (show)

See Also:

Attachments
Reverts r205383 and fixes the crash (6.58 KB, patch)
2016-09-02 19:10 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2016-09-02 19:00:45 PDT 
Fix whenDefined with a crash fix after https://trac.webkit.org/changeset/205383.
Comment 1 Radar WebKit Bug Importer 2016-09-02 19:01:43 PDT 
<rdar://problem/28146962>
Comment 2 Ryosuke Niwa 2016-09-02 19:10:18 PDT 
Created attachment 287848 [details]
Reverts r205383 and fixes the crash
Comment 3 Ryosuke Niwa 2016-09-03 16:06:35 PDT 
Comment on attachment 287848 [details]
Reverts r205383 and fixes the crash

Thanks for the review!

I'll monitor https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fdom%2FAttr%2Faccess-after-element-destruction.html to make sure this doesn't reintroduce the crash.
Comment 4 WebKit Commit Bot 2016-09-03 16:27:43 PDT 
Comment on attachment 287848 [details]
Reverts r205383 and fixes the crash

Clearing flags on attachment: 287848

Committed r205410: <http://trac.webkit.org/changeset/205410>
Comment 5 WebKit Commit Bot 2016-09-03 16:27:50 PDT 
All reviewed patches have been landed.  Closing bug.