[Mac] Remove unnecessary RetainPtr in NeverDestroyed value

[Joseph Pecoraro]

Remove unnecessary RetainPtr in NeverDestroyed value:

    WebCore/platform/ios/WebCoreMotionManager.mm
    72:    static NeverDestroyed<RetainPtr<WebCoreMotionManager>> sharedMotionManager([[WebCoreMotionManager alloc] init]);

The NeverDestroyed can just hold the allocated pointer.

[Joseph Pecoraro]

Created attachment 287825 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Comment on attachment 287825 [details]
[PATCH] Proposed Fix

Typo.

[Joseph Pecoraro]

Created attachment 287827 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Comment on attachment 287827 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=287827&action=review

> Source/WebCore/platform/ios/WebCoreMotionManager.mm:71
> +    static NeverDestroyed<WebCoreMotionManager *> sharedMotionManager([[WebCoreMotionManager alloc] init]);
> +    return sharedMotionManager.get();

Alternatively this could just be:

    static WebCoreMotionManager* sharedManager = [[WebCoreMotionManager alloc] init];
    return sharedMotionManager;

Which I think is probably the best. So I'll just write a patch for that!

[Joseph Pecoraro]

Created attachment 287829 [details]
[PATCH] Proposed Fix

[WebKit Commit Bot]

Comment on attachment 287829 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 287829

Committed r205391: <http://trac.webkit.org/changeset/205391>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 287829 [details]
[PATCH] Proposed Fix

Should we grep for NeverDestroyed and RetainPtr on the same line?