WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
161541
GetByValWithThis: fix opInfo in DFG creation
https://bugs.webkit.org/show_bug.cgi?id=161541
Summary
GetByValWithThis: fix opInfo in DFG creation
JF Bastien
Reported
2016-09-02 12:02:20 PDT
See:
https://bugs.webkit.org/show_bug.cgi?id=160922#c7
Saam points out that I addToGraph with the first opInfo instead of the second. IIUC that pipes into DFG's Node class, whose getHeapPrediction() does: return m_opInfo2.as<SpeculatedType>();
Attachments
patch
(1.97 KB, patch)
2016-09-02 12:05 PDT
,
JF Bastien
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
JF Bastien
Comment 1
2016-09-02 12:05:30 PDT
Created
attachment 287792
[details]
patch Perf numbers are pretty noisy, it seems 1.0148x faster or so.
WebKit Commit Bot
Comment 2
2016-09-02 12:19:21 PDT
Comment on
attachment 287792
[details]
patch Clearing flags on attachment: 287792 Committed
r205361
: <
http://trac.webkit.org/changeset/205361
>
WebKit Commit Bot
Comment 3
2016-09-02 12:19:26 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug