Bug 161541 - GetByValWithThis: fix opInfo in DFG creation
Summary: GetByValWithThis: fix opInfo in DFG creation
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: JF Bastien
Depends on:
Reported: 2016-09-02 12:02 PDT by JF Bastien
Modified: 2016-09-02 12:19 PDT (History)
5 users (show)

See Also:

patch (1.97 KB, patch)
2016-09-02 12:05 PDT, JF Bastien
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description JF Bastien 2016-09-02 12:02:20 PDT
See: https://bugs.webkit.org/show_bug.cgi?id=160922#c7
Saam points out that I addToGraph with the first opInfo instead of the second. IIUC that pipes into DFG's Node class, whose getHeapPrediction() does: return m_opInfo2.as<SpeculatedType>();
Comment 1 JF Bastien 2016-09-02 12:05:30 PDT
Created attachment 287792 [details]

Perf numbers are pretty noisy, it seems 1.0148x faster or so.
Comment 2 WebKit Commit Bot 2016-09-02 12:19:21 PDT
Comment on attachment 287792 [details]

Clearing flags on attachment: 287792

Committed r205361: <http://trac.webkit.org/changeset/205361>
Comment 3 WebKit Commit Bot 2016-09-02 12:19:26 PDT
All reviewed patches have been landed.  Closing bug.