REGRESSION: LayoutTest http/tests/security/cross-origin-plugin-allowed.html is a flaky failure https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/builds/9113 https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fsecurity%2Fcross-origin-plugin-allowed.html --- /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/http/tests/security/cross-origin-plugin-allowed-expected.txt +++ /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/http/tests/security/cross-origin-plugin-allowed-actual.txt @@ -8,7 +8,7 @@ -------- Frame: '<!--framePath //<!--frame0-->-->' -------- -false +undefined -------- Frame: '<!--framePath //<!--frame1-->-->'
Marked as flaky in http://trac.webkit.org/projects/webkit/changeset/205525
First failure was ~r205224, but the failure is flaky and that change does not appear to be directly related.
Seems solid now. No issues on the flakiness dashboard, and local testing passes. Note that the iOS test is still marked as failing. The test relies on a netscape-style plugin, which is is not enabled on iOS.
<rdar://problem/39389781>
Created attachment 337820 [details] Patch
Feel free to land this as test gardening.
Landed in <https://trac.webkit.org/changeset/230611/webkit>.
Comment on attachment 337820 [details] Patch This has been requesting review for more than one year. If this is still needed, please rebase and re-request review.