Bug 161539 - REGRESSION: [mac-wk2 release] LayoutTest http/tests/security/cross-origin-plugin-allowed.html is a flaky failure
Summary: REGRESSION: [mac-wk2 release] LayoutTest http/tests/security/cross-origin-plu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-09-02 11:27 PDT by Ryan Haddad
Modified: 2018-04-12 16:44 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.63 KB, patch)
2018-04-12 12:24 PDT, Keith Rollin
krollin: review?
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2016-09-02 11:27:32 PDT
REGRESSION: LayoutTest http/tests/security/cross-origin-plugin-allowed.html is a flaky failure

https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/builds/9113

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fsecurity%2Fcross-origin-plugin-allowed.html

--- /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/http/tests/security/cross-origin-plugin-allowed-expected.txt
+++ /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/http/tests/security/cross-origin-plugin-allowed-actual.txt
@@ -8,7 +8,7 @@
 --------
 Frame: '<!--framePath //<!--frame0-->-->'
 --------
-false
+undefined
 
 --------
 Frame: '<!--framePath //<!--frame1-->-->'
Comment 1 Ryan Haddad 2016-09-06 17:03:43 PDT
Marked as flaky in http://trac.webkit.org/projects/webkit/changeset/205525
Comment 2 Ryan Haddad 2016-09-06 17:05:58 PDT
First failure was ~r205224, but the failure is flaky and that change does not appear to be directly related.
Comment 3 Keith Rollin 2018-04-12 12:22:03 PDT
Seems solid now. No issues on the flakiness dashboard, and local testing passes.

Note that the iOS test is still marked as failing. The test relies on a netscape-style plugin, which is is not enabled on iOS.
Comment 4 Radar WebKit Bug Importer 2018-04-12 12:22:24 PDT
<rdar://problem/39389781>
Comment 5 Keith Rollin 2018-04-12 12:24:56 PDT
Created attachment 337820 [details]
Patch
Comment 6 Ryan Haddad 2018-04-12 14:39:19 PDT
Feel free to land this as test gardening.
Comment 7 Keith Rollin 2018-04-12 16:44:02 PDT
Landed in <https://trac.webkit.org/changeset/230611/webkit>.