Bug 161522 - Add toJS for JSC::PrivateName
Summary: Add toJS for JSC::PrivateName
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks: 148897
  Show dependency tree / graph
 
Reported: 2016-09-01 19:51 PDT by Yusuke Suzuki
Modified: 2016-09-01 20:44 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.56 KB, patch)
2016-09-01 19:53 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (9.99 KB, patch)
2016-09-01 20:23 PDT, Yusuke Suzuki 		rniwa: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2016-09-01 19:51:19 PDT 
Add toJS for JSC::PrivateName
Comment 1 Yusuke Suzuki 2016-09-01 19:53:43 PDT 
Created attachment 287717 [details]
Patch
Comment 2 Yusuke Suzuki 2016-09-01 19:54:45 PDT 
Comment on attachment 287717 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=287717&action=review

> Source/WebCore/bindings/js/JSDOMBinding.h:581
> +    return JSC::Symbol::create(exec->vm(), *privateName.uid());

I'll update this uid() to return reference.
Comment 3 WebKit Commit Bot 2016-09-01 19:55:22 PDT 
Attachment 287717 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Yusuke Suzuki 2016-09-01 20:23:09 PDT 
Created attachment 287721 [details]
Patch
Comment 5 Ryosuke Niwa 2016-09-01 20:30:18 PDT 
Comment on attachment 287721 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=287721&action=review

> Source/JavaScriptCore/ChangeLog:8
> +        Add the export annotation.

Why are you making hold Ref instead of RefPtr?  Is that an unrelated refactoring?
Please clarify that in the channel log before landing this.
Comment 6 Yusuke Suzuki 2016-09-01 20:37:05 PDT 
Comment on attachment 287721 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=287721&action=review

>> Source/JavaScriptCore/ChangeLog:8
>> +        Add the export annotation.
> 
> Why are you making hold Ref instead of RefPtr?  Is that an unrelated refactoring?
> Please clarify that in the channel log before landing this.

Thanks. I noted that.
Comment 7 Yusuke Suzuki 2016-09-01 20:44:06 PDT 
Committed r205335: <http://trac.webkit.org/changeset/205335>