RESOLVED FIXED 161511
Avoid unneeded string copy when parsing URL hosts 
https://bugs.webkit.org/show_bug.cgi?id=161511
Summary Avoid unneeded string copy when parsing URL hosts
Alex Christensen
Reported 2016-09-01 14:39:36 PDT
Avoid unneeded string copy when parsing URL hosts
Attachments
Patch (5.82 KB, patch)
2016-09-01 14:41 PDT, Alex Christensen 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2016-09-01 14:41:19 PDT
Created attachment 287683 [details] Patch
Alex Christensen
Comment 2 2016-09-01 14:52:50 PDT
https://trac.webkit.org/changeset/205318
Darin Adler
Comment 3 2016-09-03 08:38:16 PDT
Comment on attachment 287683 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=287683&action=review > Source/WebCore/platform/URLParser.h:46 > + void parseAuthority(StringView::CodePoints::Iterator&, const StringView::CodePoints::Iterator& end); > + void parseHost(StringView::CodePoints::Iterator&, const StringView::CodePoints::Iterator& end); Why these pairs of arguments instead of a StringView?
Alex Christensen
Comment 4 2016-09-06 14:44:44 PDT
At the time I need to call these functions, all I have is StringView::CodePoints::Iterators. I'm not sure how to make a StringView out of iterators.
Note You need to log in before you can comment on or make changes to this bug.