Bug 161510 - Web Inspector: NetworkTimelineOverviewGraph.MinimumBarPaddingTime is undefined
Summary: Web Inspector: NetworkTimelineOverviewGraph.MinimumBarPaddingTime is undefined
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-09-01 14:25 PDT by Johan K. Jensen
Modified: 2016-09-02 10:48 PDT (History)
7 users (show)

See Also:


Attachments
Patch (4.92 KB, patch)
2016-09-01 14:36 PDT, Johan K. Jensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Johan K. Jensen 2016-09-01 14:25:08 PDT
WebInspector.NetworkTimelineOverviewGraph.MinimumBarPaddingTime is undefined which causes new network record bars to be always be dumped on the next row in the NetworkTimelineOverview instead of rows where they might be able to fit in.
Comment 1 Radar WebKit Bug Importer 2016-09-01 14:25:30 PDT
<rdar://problem/28123169>
Comment 2 Johan K. Jensen 2016-09-01 14:36:49 PDT
Created attachment 287682 [details]
Patch
Comment 3 Brian Burg 2016-09-01 16:28:03 PDT
Comment on attachment 287682 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=287682&action=review

r=me

> Source/WebInspectorUI/ChangeLog:12
> +        by using MinimumWidthPixel, MinimumMarginPixel and MinimumDurationPerPixel as the secondsPerPixel value.

I do not know if similar values are used by network overview, as it is a different algorithm. But it seems more sensible that giving up.
Comment 4 WebKit Commit Bot 2016-09-02 10:48:08 PDT
Comment on attachment 287682 [details]
Patch

Clearing flags on attachment: 287682

Committed r205349: <http://trac.webkit.org/changeset/205349>
Comment 5 WebKit Commit Bot 2016-09-02 10:48:20 PDT
All reviewed patches have been landed.  Closing bug.