Bug 16149 - [GTK] Implement the window-object-cleared signal
Summary: [GTK] Implement the window-object-cleared signal
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Gtk (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks: 15687
  Show dependency treegraph
 
Reported: 2007-11-26 16:02 PST by Alp Toker
Modified: 2007-11-27 06:05 PST (History)
0 users

See Also:


Attachments
Add support for this signal (7.34 KB, patch)
2007-11-26 16:21 PST, Alp Toker
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alp Toker 2007-11-26 16:02:26 PST
This is an important hook to give applications access to the JS engine.
Comment 1 Alp Toker 2007-11-26 16:21:33 PST
Created attachment 17540 [details]
Add support for this signal
Comment 2 Adam Roben (:aroben) 2007-11-26 17:40:03 PST
Comment on attachment 17540 [details]
Add support for this signal

+    void (*window_object_cleared) (WebKitPage* page, WebKitFrame* frame, JSContextRef context, JSObjectRef window_object);

window_object should be a JSGlobalContextRef (it's a mistake in the Windows port that this is not the case).

+    // TODO: Re-attach debug clients if present.
+    // The Win port has an example of how we might do this.
+    //detachScriptDebugger();
+    //attachScriptDebugger();

We generally don't like to leave commented-out code in the source tree.

r=me
Comment 3 Alp Toker 2007-11-26 18:08:25 PST
Landed in r28065.