Bug 161484 - [GTK] GL_PACK_ROW_LENGTH is not available in GLES2
Summary: [GTK] GL_PACK_ROW_LENGTH is not available in GLES2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gustavo Noronha (kov)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-01 04:28 PDT by memeka
Modified: 2016-09-05 07:24 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.95 KB, patch)
2016-09-02 11:43 PDT, Gustavo Noronha (kov) 		cgarcia: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description memeka 2016-09-01 04:28:04 PDT 
Source/WebKit2/UIProcess/gtk/AcceleratedBackingStoreWayland.cpp

AcceleratedBackingStoreWayland::paint

makes use of GL_PACK_ROW_LENGTH, which is missing in many (egl/gles) platforms
Comment 1 memeka 2016-09-01 04:54:14 PDT 
for my GPU (mali 768) i found GL_PACK_ROW_LENGTH is a GLES3 function

in GLES3/gl3.h:

#ifndef GL_ES_VERSION_3_0
#define GL_ES_VERSION_3_0 1
typedef unsigned short GLhalf;
#define GL_READ_BUFFER                    0x0C02
#define GL_UNPACK_ROW_LENGTH              0x0CF2
#define GL_UNPACK_SKIP_ROWS               0x0CF3
#define GL_UNPACK_SKIP_PIXELS             0x0CF4
#define GL_PACK_ROW_LENGTH                0x0D02

...


but maybe it should be replaced by a GLES2 function for better compatibility.
Comment 2 Gustavo Noronha (kov) 2016-09-02 11:43:26 PDT 
Created attachment 287790 [details]
Patch
Comment 3 Gustavo Noronha (kov) 2016-09-05 07:24:16 PDT 
Committed r205452: <http://trac.webkit.org/changeset/205452>