Bug 161482 - [GStreamer] build fails with ACCELERATED_2D_CANVAS disabled
Summary: [GStreamer] build fails with ACCELERATED_2D_CANVAS disabled
Status: RESOLVED DUPLICATE of bug 161594
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-01 03:15 PDT by Philippe Normand
Modified: 2016-09-04 23:58 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2016-09-01 03:15:31 PDT 
We have:

#if USE(CAIRO) && ENABLE(ACCELERATED_2D_CANVAS)
#include <cairo-gl.h>
#endif

but in MediaPlayerPrivateGStreamerBase::nativeImageForCurrentTime():

#if !USE(CAIRO) || !ENABLE(ACCELERATED_2D_CANVAS)
    return nullptr;
#endif

I think the ifdef wrapping the #include should be USE(CAIRO) && ENABLE(OPENGL) or something similar.
Comment 1 Philippe Normand 2016-09-01 03:31:39 PDT 
The build error is that cairo_gl_device_set_thread_aware() isn't found because cairo-gl.h isn't included.
Comment 2 Zan Dobersek 2016-09-04 23:58:22 PDT 

*** This bug has been marked as a duplicate of bug 161594 ***