Bug 161476 - YouTube Flash plug-in replacement facility should more gracefully handle malformed queries
Summary: YouTube Flash plug-in replacement facility should more gracefully handle malf...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ricky Mondello
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-31 23:21 PDT by Ricky Mondello
Modified: 2016-09-01 12:29 PDT (History)
7 users (show)

See Also:

Attachments
first attempt (9.88 KB, patch)
2016-08-31 23:38 PDT, Ricky Mondello 		eric.carlson: review+
Details | Formatted Diff | Diff
same as last time, with a few renames (10.06 KB, patch)
2016-09-01 11:37 PDT, Ricky Mondello 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ricky Mondello 2016-08-31 23:21:37 PDT 
YouTube Flash plug-in replacement facility should more gracefully handle malformed queries

Some YouTube Flash embeds use '&' instead of '?' to start the query portion of the URL. Here's an example: http://www.youtube.com/v/dQw4w9WgXcQ&start=4

Our implementation drops everything including and after the &. Instead, we should treat the & like a ? and restore the query when we're done. If we do this, it means embeds for a particular timecode will be preserved.
Comment 1 Ricky Mondello 2016-08-31 23:38:16 PDT 
Created attachment 287604 [details]
first attempt
Comment 2 Eric Carlson 2016-09-01 09:30:32 PDT 
Comment on attachment 287604 [details]
first attempt

View in context: https://bugs.webkit.org/attachment.cgi?id=287604&action=review

> Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp:203
> +static URL processAndCreateYouTubeURL(const URL& url, bool& isYouTubeShortenedURL, String& outMalformedQuery)

"malformedQuery" doesn't seem right, although I don't have any great suggestions. Maybe "unusedParameters"?
Comment 3 Ricky Mondello 2016-09-01 11:37:15 PDT 
Created attachment 287643 [details]
same as last time, with a few renames
Comment 4 WebKit Commit Bot 2016-09-01 12:29:53 PDT 
Comment on attachment 287643 [details]
same as last time, with a few renames

Clearing flags on attachment: 287643

Committed r205306: <http://trac.webkit.org/changeset/205306>
Comment 5 WebKit Commit Bot 2016-09-01 12:29:57 PDT 
All reviewed patches have been landed.  Closing bug.