Bug 161470 - [JSC] Add initiator parameter to module pipeline
Summary: [JSC] Add initiator parameter to module pipeline
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks: 148897
  Show dependency tree / graph
 
Reported: 2016-08-31 19:23 PDT by Yusuke Suzuki
Modified: 2016-08-31 20:53 PDT (History)
1 user (show)

See Also:

Attachments
Patch (88.45 KB, patch)
2016-08-31 19:35 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2016-08-31 19:23:47 PDT 
[JSC] Add initiator parameter to module pipeline
Comment 1 Yusuke Suzuki 2016-08-31 19:35:20 PDT 
Created attachment 287585 [details]
Patch
Comment 2 Yusuke Suzuki 2016-08-31 19:49:54 PDT 
Comment on attachment 287585 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=287585&action=review

> Source/JavaScriptCore/ChangeLog:9
> +        For example, "nonce", "crossorigin" etc. attributes are shared in the fetching issued

typo, "in the fetching" => "in the fetching requests".
Comment 3 Saam Barati 2016-08-31 20:00:26 PDT 
Comment on attachment 287585 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=287585&action=review

r=me

> Source/WebCore/bindings/js/JSMainThreadExecState.h:95
> +    static JSC::JSInternalPromise* loadModule(JSC::ExecState* exec, const String& moduleName, JSC::JSValue initiator)

Please update this file's copyright before landing.
Comment 4 Yusuke Suzuki 2016-08-31 20:47:32 PDT 
Oops, accidentally cleared r+. Land that manually.
Comment 5 Yusuke Suzuki 2016-08-31 20:50:31 PDT 
Committed r205278: <http://trac.webkit.org/changeset/205278>