RESOLVED FIXED 161465
[Mac] Web Inspector: Remove stale inspector process termination code 
https://bugs.webkit.org/show_bug.cgi?id=161465
Summary [Mac] Web Inspector: Remove stale inspector process termination code
Joseph Pecoraro
Reported 2016-08-31 16:38:42 PDT
Summary: Remove stale inspector process termination code This code doesn't appear to get run when the WebContentProcess inside of an Inspector Process gets killed. Instead the general WebInspectorProxy webProcessDidCrash closes the proxy. So this code appears to be unreachable and stale.
Attachments
[PATCH] Proposed Fix (3.71 KB, patch)
2016-08-31 16:41 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-08-31 16:39:17 PDT
<rdar://problem/28106584>
Joseph Pecoraro
Comment 2 2016-08-31 16:41:12 PDT
Created attachment 287564 [details] [PATCH] Proposed Fix
Blaze Burg
Comment 3 2016-09-01 10:49:48 PDT
Comment on attachment 287564 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=287564&action=review r=me > Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:-165 > -- (void)_didRelaunchProcess This is an override from WKWebViewPrivate, but the base implementation only does anything for iOS, and it's only called from PageClientImplIOS.mm. I wonder why we went this route...
WebKit Commit Bot
Comment 4 2016-09-01 11:10:47 PDT
Comment on attachment 287564 [details] [PATCH] Proposed Fix Clearing flags on attachment: 287564 Committed r205299: <http://trac.webkit.org/changeset/205299>
WebKit Commit Bot
Comment 5 2016-09-01 11:10:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.