Bug 161465 - [Mac] Web Inspector: Remove stale inspector process termination code
Summary: [Mac] Web Inspector: Remove stale inspector process termination code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-08-31 16:38 PDT by Joseph Pecoraro
Modified: 2016-09-01 11:10 PDT (History)
7 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (3.71 KB, patch)
2016-08-31 16:41 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-08-31 16:38:42 PDT 
Summary:
Remove stale inspector process termination code

This code doesn't appear to get run when the WebContentProcess inside of an Inspector Process gets killed.

Instead the general WebInspectorProxy webProcessDidCrash closes the proxy. So this code appears to be unreachable and stale.
Comment 1 Radar WebKit Bug Importer 2016-08-31 16:39:17 PDT 
<rdar://problem/28106584>
Comment 2 Joseph Pecoraro 2016-08-31 16:41:12 PDT 
Created attachment 287564 [details]
[PATCH] Proposed Fix
Comment 3 BJ Burg 2016-09-01 10:49:48 PDT 
Comment on attachment 287564 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=287564&action=review

r=me

> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:-165
> -- (void)_didRelaunchProcess

This is an override from WKWebViewPrivate, but the base implementation only does anything for iOS, and it's only called from PageClientImplIOS.mm. I wonder why we went this route...
Comment 4 WebKit Commit Bot 2016-09-01 11:10:47 PDT 
Comment on attachment 287564 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 287564

Committed r205299: <http://trac.webkit.org/changeset/205299>
Comment 5 WebKit Commit Bot 2016-09-01 11:10:51 PDT 
All reviewed patches have been landed.  Closing bug.