Bug 161461 - FocusController should pass KeyboardEvent around by reference.
Summary: FocusController should pass KeyboardEvent around by reference.
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Depends on:
Reported: 2016-08-31 15:07 PDT by Andreas Kling
Modified: 2016-09-01 07:24 PDT (History)
1 user (show)

See Also:

Patch (19.71 KB, patch)
2016-08-31 15:08 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2016-08-31 15:07:49 PDT
KeyboardEvent* -> KeyboardEvent&
Comment 1 Andreas Kling 2016-08-31 15:08:40 PDT
Created attachment 287548 [details]
Comment 2 WebKit Commit Bot 2016-08-31 15:11:35 PDT
Attachment 287548 [details] did not pass style-queue:

ERROR: Source/WebCore/page/FocusController.cpp:399:  'event' is incorrectly named. It should be named 'protector' or 'protectedProvidedEvent'.  [readability/naming/protected] [4]
Total errors found: 1 in 4 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2016-09-01 07:24:26 PDT
Comment on attachment 287548 [details]

Clearing flags on attachment: 287548

Committed r205290: <http://trac.webkit.org/changeset/205290>
Comment 4 WebKit Commit Bot 2016-09-01 07:24:30 PDT
All reviewed patches have been landed.  Closing bug.