The GTK+ backend currently doesn't implement media playback support for HTML 5. It should be done with GStreamer. I am working on it.
Nice!
Created attachment 17677 [details] First try First version to be reviewed.
I haven't looked too closely yet, but apart from the small coding issues we discussed earlier, this looks great! +gtk-port:DEFINES += ENABLE_VIDEO=1 We'll need to change that so VIDEO is only enabled when gtk-port is being compiled using the x11 backend, since the GStreamer backend is x11-specific right now. In fact it might be best to have video disabled by default for a couple of weeks until we make the feature usable and figure out how check for availability of GStreamer/gnome-vfs properly in the build system. I'd be happy to help complete this feature at some point (making the video render in the right place) if you don't have the time to do it yourself. Really nice work :-)
Created attachment 17685 [details] 2nd try Fix licensing (now LGPL), re-apply coding conventions, disable by default on Gtk+ port.
Comment on attachment 17685 [details] 2nd try r=me There are a few glaring style issues I'll clean up before landing, and a few more that should probably be fixed once this is in, hopefully along with patches to complete the feature. Thanks!
Landed in r28389 with a few minor cleanups. Thanks!
Created attachment 17725 [details] More clean-up Further clean up of the code. Removed unnecessary code and commented code. Variables now uses the code style guidelines.
Comment on attachment 17685 [details] 2nd try Clearing review flag as this was landed.
Comment on attachment 17725 [details] More clean-up r=me Looking much cleaner. ChangeLog next time please.