161447 – Reverse ownership relation of StyleCachedImage and CSSImageValue

RESOLVED FIXED 161447

Reverse ownership relation of StyleCachedImage and CSSImageValue

https://bugs.webkit.org/show_bug.cgi?id=161447

Summary Reverse ownership relation of StyleCachedImage and CSSImageValue

Antti Koivisto

Reported 2016-08-31 11:55:43 PDT

StyleCachedImage should ref the CSSValue that is backing it, not the other way round. This is how StyleGeneratedImage works already and will make the code more sane.

Attachments
patch (31.49 KB, patch) 2016-08-31 12:52 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (30.62 KB, patch) 2016-08-31 12:58 PDT, Antti Koivisto	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (1.11 MB, application/zip) 2016-08-31 13:35 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews100 for mac-yosemite (843.31 KB, application/zip) 2016-08-31 13:49 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews112 for mac-yosemite (1.47 MB, application/zip) 2016-08-31 14:00 PDT, Build Bot	no flags	Details
patch (32.77 KB, patch) 2016-09-02 05:25 PDT, Antti Koivisto	kling: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-yosemite (1002.75 KB, application/zip) 2016-09-02 06:15 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (890.68 KB, application/zip) 2016-09-02 06:19 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews114 for mac-yosemite (1.51 MB, application/zip) 2016-09-02 06:23 PDT, Build Bot	no flags	Details
patch (34.10 KB, patch) 2016-09-02 06:55 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (40.71 KB, patch) 2016-09-04 05:30 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2016-08-31 12:52:12 PDT

Created attachment 287530 [details] patch

Antti Koivisto

Comment 2 2016-08-31 12:58:19 PDT

Created attachment 287532 [details] patch

Build Bot

Comment 3 2016-08-31 13:35:02 PDT

Comment on attachment 287532 [details] patch Attachment 287532 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1982160 New failing tests: fast/events/mouse-cursor-image-set.html

Build Bot

Comment 4 2016-08-31 13:35:05 PDT

Created attachment 287534 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 5 2016-08-31 13:49:13 PDT

Comment on attachment 287532 [details] patch Attachment 287532 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1982240 New failing tests: fast/events/mouse-cursor-image-set.html

Build Bot

Comment 6 2016-08-31 13:49:17 PDT

Created attachment 287537 [details] Archive of layout-test-results from ews100 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 7 2016-08-31 14:00:57 PDT

Comment on attachment 287532 [details] patch Attachment 287532 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1982249 New failing tests: fast/events/mouse-cursor-image-set.html

Build Bot

Comment 8 2016-08-31 14:00:59 PDT

Created attachment 287540 [details] Archive of layout-test-results from ews112 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-yosemite Platform: Mac OS X 10.10.5

Antti Koivisto

Comment 9 2016-09-02 05:25:45 PDT

Created attachment 287752 [details] patch

Andreas Kling

Comment 10 2016-09-02 06:13:17 PDT

Comment on attachment 287752 [details] patch r=me, this looks very nice. Please fix the test failure before landing though!

Build Bot

Comment 11 2016-09-02 06:15:14 PDT

Comment on attachment 287752 [details] patch Attachment 287752 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1993697 New failing tests: fast/repaint/multiple-backgrounds-style-change.html

Build Bot

Comment 12 2016-09-02 06:15:18 PDT

Created attachment 287753 [details] Archive of layout-test-results from ews100 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 13 2016-09-02 06:19:36 PDT

Comment on attachment 287752 [details] patch Attachment 287752 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1993708 New failing tests: fast/repaint/multiple-backgrounds-style-change.html

Build Bot

Comment 14 2016-09-02 06:19:40 PDT

Created attachment 287754 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 15 2016-09-02 06:23:22 PDT

Comment on attachment 287752 [details] patch Attachment 287752 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1993702 New failing tests: fast/repaint/multiple-backgrounds-style-change.html

Build Bot

Comment 16 2016-09-02 06:23:26 PDT

Created attachment 287755 [details] Archive of layout-test-results from ews114 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5

Antti Koivisto

Comment 17 2016-09-02 06:55:36 PDT

Created attachment 287756 [details] patch

WebKit Commit Bot

Comment 18 2016-09-02 07:29:55 PDT

Comment on attachment 287756 [details] patch Clearing flags on attachment: 287756 Committed r205344: <http://trac.webkit.org/changeset/205344>

WebKit Commit Bot

Comment 19 2016-09-02 07:30:09 PDT

All reviewed patches have been landed. Closing bug.

WebKit Commit Bot

Comment 20 2016-09-02 09:25:26 PDT

Re-opened since this is blocked by bug 161533

Antti Koivisto

Comment 21 2016-09-04 05:30:45 PDT

Created attachment 287901 [details] patch

WebKit Commit Bot

Comment 22 2016-09-04 06:44:38 PDT

Comment on attachment 287901 [details] patch Clearing flags on attachment: 287901 Committed r205419: <http://trac.webkit.org/changeset/205419>

WebKit Commit Bot

Comment 23 2016-09-04 06:44:45 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component CSS

Assignee

Nobody

Reported

2016-08-31 11:55 PDT

Modified

2016-09-04 06:44 PDT History

CC List

4 users Show

URL

Keywords

Depends on

161533

Blocks

Dependencies

tree graph