Bug 161439 - Clear LoadFinishTime from a CachedResource when fetched from cache
Summary: Clear LoadFinishTime from a CachedResource when fetched from cache
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-31 09:25 PDT by Johan K. Jensen
Modified: 2016-09-09 16:53 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.65 KB, patch)
2016-08-31 09:26 PDT, Johan K. Jensen 		achristensen: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Johan K. Jensen 2016-08-31 09:25:02 PDT 
Clear LoadFinishTime from a CachedResource when fetched from cache.
Comment 1 Johan K. Jensen 2016-08-31 09:26:02 PDT 
Created attachment 287513 [details]
Patch
Comment 2 Alex Christensen 2016-08-31 14:45:13 PDT 
Comment on attachment 287513 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=287513&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests, internal change.

Does this make tests less flaky?  Are there inspector tests for this?
Comment 3 WebKit Commit Bot 2016-09-09 16:53:16 PDT 
Comment on attachment 287513 [details]
Patch

Rejecting attachment 287513 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 287513, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 2 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/loader/cache/CachedResourceLoader.cpp
Hunk #1 FAILED at 642.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/loader/cache/CachedResourceLoader.cpp.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Alex Christensen']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/2044145