Bug 161428 - [EFL] Small clean up in MiniBrowser
Summary: [EFL] Small clean up in MiniBrowser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-31 00:09 PDT by Gyuyoung Kim
Modified: 2016-08-31 22:50 PDT (History)
3 users (show)

See Also:

Attachments
Patch (15.87 KB, patch)
2016-08-31 00:10 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (15.86 KB, patch)
2016-08-31 17:52 PDT, Gyuyoung Kim 		ysuzuki: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2016-08-31 00:09:30 PDT 
Do below stuff.

- Resize MiniBrowser size
- Remove unnecessary spaces
- Line breaking in too long line
- Add const characters for scheme.
Comment 1 Gyuyoung Kim 2016-08-31 00:10:42 PDT 
Created attachment 287497 [details]
Patch
Comment 2 Gyuyoung Kim 2016-08-31 17:52:32 PDT 
Created attachment 287580 [details]
Patch
Comment 3 Yusuke Suzuki 2016-08-31 21:42:39 PDT 
Comment on attachment 287580 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=287580&action=review

r=me

> Tools/MiniBrowser/efl/main.c:-1060
> -        eina_strbuf_append_printf(buf, "http://%s", arg);

Why not using  `eina_strbuf_append_printf(buf, "%s%s", HTTP_SCHEME, arg);`?
Comment 4 Gyuyoung Kim 2016-08-31 22:49:11 PDT 
Committed r205279: <http://trac.webkit.org/changeset/205279>
Comment 5 Gyuyoung Kim 2016-08-31 22:50:03 PDT 
(In reply to comment #3)
> Comment on attachment 287580 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=287580&action=review
> 
> r=me
> 
> > Tools/MiniBrowser/efl/main.c:-1060
> > -        eina_strbuf_append_printf(buf, "http://%s", arg);
> 
> Why not using  `eina_strbuf_append_printf(buf, "%s%s", HTTP_SCHEME, arg);`?

Sure, land after fixing it.