Bug 161425 - Add "whenDefined" to CustomElementRegistry
Summary: Add "whenDefined" to CustomElementRegistry
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on: 161426
Blocks: 154907
  Show dependency tree / graph
 
Reported: 2016-08-30 22:30 PDT by Ryosuke Niwa
Modified: 2016-09-01 16:17 PDT (History)
11 users (show)

See Also:

Attachments
Added the support (19.38 KB, patch)
2016-08-31 20:07 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Fixed change logs (19.34 KB, patch)
2016-08-31 20:09 PDT, Ryosuke Niwa 		ysuzuki: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews115 for mac-yosemite (1.50 MB, application/zip)
2016-08-31 21:50 PDT, Build Bot 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2016-08-30 22:30:35 PDT 
Add the support for “whenDefined” method on CustomElementRegistry:
https://html.spec.whatwg.org/#dom-customelementregistry-whendefined
Comment 1 Ryosuke Niwa 2016-08-31 20:07:10 PDT 
Created attachment 287587 [details]
Added the support
Comment 2 Ryosuke Niwa 2016-08-31 20:09:51 PDT 
Created attachment 287588 [details]
Fixed change logs
Comment 3 Build Bot 2016-08-31 21:50:50 PDT 
Comment on attachment 287588 [details]
Fixed change logs

Attachment 287588 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1984634

New failing tests:
fast/dom/HTMLElement/class-list-gc.html
Comment 4 Build Bot 2016-08-31 21:50:55 PDT 
Created attachment 287598 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 5 Yusuke Suzuki 2016-09-01 14:01:23 PDT 
Comment on attachment 287588 [details]
Fixed change logs

View in context: https://bugs.webkit.org/attachment.cgi?id=287588&action=review

r=me

> Source/WebCore/bindings/js/JSCustomElementRegistryCustom.cpp:188
> +        return jsUndefined();

Adding a test for this case would be nice.
Comment 6 Ryosuke Niwa 2016-09-01 14:02:58 PDT 
Comment on attachment 287588 [details]
Fixed change logs

View in context: https://bugs.webkit.org/attachment.cgi?id=287588&action=review

Thanks for the review!

>> Source/WebCore/bindings/js/JSCustomElementRegistryCustom.cpp:188
>> +        return jsUndefined();
> 
> Adding a test for this case would be nice.

Oh oops, I did have some test cases but somehow got lost during merge.
Will add them back.
Comment 7 Ryosuke Niwa 2016-09-01 14:48:29 PDT 
Landed in https://trac.webkit.org/changeset/205315.
Comment 8 Ryosuke Niwa 2016-09-01 16:17:58 PDT 
<rdar://problem/28091073>