Bug 161425 – Add "whenDefined" to CustomElementRegistry

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Ryosuke Niwa]

Add the support for “whenDefined” method on CustomElementRegistry:
https://html.spec.whatwg.org/#dom-customelementregistry-whendefined

[Ryosuke Niwa]

Created attachment 287587 [details]
Added the support

[Ryosuke Niwa]

Created attachment 287588 [details]
Fixed change logs

[Build Bot]

Comment on attachment 287588 [details]
Fixed change logs

Attachment 287588 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1984634

New failing tests:
fast/dom/HTMLElement/class-list-gc.html

[Build Bot]

Created attachment 287598 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Yusuke Suzuki]

Comment on attachment 287588 [details]
Fixed change logs

View in context: https://bugs.webkit.org/attachment.cgi?id=287588&action=review

r=me

> Source/WebCore/bindings/js/JSCustomElementRegistryCustom.cpp:188
> +        return jsUndefined();

Adding a test for this case would be nice.

[Ryosuke Niwa]

Comment on attachment 287588 [details]
Fixed change logs

View in context: https://bugs.webkit.org/attachment.cgi?id=287588&action=review

Thanks for the review!

>> Source/WebCore/bindings/js/JSCustomElementRegistryCustom.cpp:188
>> +        return jsUndefined();
> 
> Adding a test for this case would be nice.

Oh oops, I did have some test cases but somehow got lost during merge.
Will add them back.

[Ryosuke Niwa]

Landed in https://trac.webkit.org/changeset/205315.

[Ryosuke Niwa]

<rdar://problem/28091073>