Bug 161416 - "pluginReplacementEnabled" should be a Setting, not a RuntimeEnabledFeature
Summary: "pluginReplacementEnabled" should be a Setting, not a RuntimeEnabledFeature
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ricky Mondello
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-30 17:19 PDT by Ricky Mondello
Modified: 2016-08-31 13:31 PDT (History)
11 users (show)

See Also:

Attachments
First attempt (11.56 KB, patch)
2016-08-30 17:29 PDT, Ricky Mondello 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ricky Mondello 2016-08-30 17:19:23 PDT 
"pluginReplacementEnabled" should be a Setting, not a RuntimeEnabledFeature
Comment 1 Ricky Mondello 2016-08-30 17:29:54 PDT 
Created attachment 287465 [details]
First attempt
Comment 2 WebKit Commit Bot 2016-08-30 18:30:26 PDT 
Comment on attachment 287465 [details]
First attempt

Clearing flags on attachment: 287465

Committed r205214: <http://trac.webkit.org/changeset/205214>
Comment 3 WebKit Commit Bot 2016-08-30 18:30:31 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Alexey Proskuryakov 2016-08-30 23:00:07 PDT 
What is the reason for this change?
Comment 5 Tim Horton 2016-08-30 23:31:18 PDT 
Ricky's going to split it into two settings, and instead of adding a new runtime enabled feature (my understanding, which mostly comes from smfr, is that we don't want to add any more of those), he's moved the existing one first (a future patch will come to do the split).
Comment 6 Dean Jackson 2016-08-31 12:43:20 PDT 
(In reply to comment #5)
> Ricky's going to split it into two settings, and instead of adding a new
> runtime enabled feature (my understanding, which mostly comes from smfr, is
> that we don't want to add any more of those), he's moved the existing one
> first (a future patch will come to do the split).

Yep. We're going to differentiate between replacing the Flash plugin and replacing other plugins.
Comment 7 Dean Jackson 2016-08-31 12:43:45 PDT 
Also <rdar://problem/28050847>
Comment 8 Alexey Proskuryakov 2016-08-31 13:30:35 PDT 
> we don't want to add any more of those

Thank you Tim! I think that for patches that touch runtime enabled features, it is especially important to explain them, given how scattered the knowledge is.
Comment 9 Alexey Proskuryakov 2016-08-31 13:31:22 PDT 
> Yep. We're going to differentiate between replacing the Flash plugin and replacing other plugins.

Also good to know!