Provide a TestWebKitAPI-wide WKNavigationDelegate to simplify tests
Created attachment 287457 [details] Patch
Attachment 287457 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLNotChange.mm:43: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLNotChange.mm:46: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm:57: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:70: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:64: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 5 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 287462 [details] Patch
Attachment 287462 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLNotChange.mm:43: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLNotChange.mm:46: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm:57: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:70: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:64: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 5 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 287462 [details] Patch Clearing flags on attachment: 287462 Committed r205329: <http://trac.webkit.org/changeset/205329>
All reviewed patches have been landed. Closing bug.
It appears that API tests WebKit2.AnimatedResizeDoesNotHang and WebKit2.ResizeWithHiddenContentDoesNotHang are timing out on ios-simulater after this change https://build.webkit.org/builders/Apple%20iOS%209%20Simulator%20Release%20WK2%20%28Tests%29/builds/8899
Weird! I'll start a sim build and fix shortly.
Oh, the mistake is clear.
Fixing in https://bugs.webkit.org/show_bug.cgi?id=161542.