Bug 161406 – YouTubePluginReplacementTest's URL transformation logic should have tests

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Ricky Mondello]

YouTubePluginReplacementTest's URL transformation logic should have tests

[Ricky Mondello]

Created attachment 287436 [details]
First attempt at adding some tests

[WebKit Commit Bot]

Attachment 287436 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp:28:  Found WebCore config.h after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp:44:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 287436 [details]
First attempt at adding some tests

View in context: https://bugs.webkit.org/attachment.cgi?id=287436&action=review

> Tools/TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp:67
> +    // Even with an extra paremeter.

Parameter.

[Ricky Mondello]

Created attachment 287438 [details]
Mind the style checker and fix a typo in a comment

[Eric Carlson]

Comment on attachment 287438 [details]
Mind the style checker and fix a typo in a comment

View in context: https://bugs.webkit.org/attachment.cgi?id=287438&action=review

> Source/WebCore/ChangeLog:5
> +        YouTubePluginReplacementTest's URL transformation logic should have tests
> +        https://bugs.webkit.org/show_bug.cgi?id=161406
> +

Nit: please include the Radar number as well.

[Ricky Mondello]

Created attachment 287453 [details]
Incorporated Eric's review feedback.

[WebKit Commit Bot]

Comment on attachment 287453 [details]
Incorporated Eric's review feedback.

Clearing flags on attachment: 287453

Committed r205212: <http://trac.webkit.org/changeset/205212>