Bug 161406 - YouTubePluginReplacementTest's URL transformation logic should have tests
Summary: YouTubePluginReplacementTest's URL transformation logic should have tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ricky Mondello
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-30 14:36 PDT by Ricky Mondello
Modified: 2016-09-01 17:55 PDT (History)
8 users (show)

See Also:

Attachments
First attempt at adding some tests (15.88 KB, patch)
2016-08-30 14:56 PDT, Ricky Mondello 		no flags Details | Formatted Diff | Diff
Mind the style checker and fix a typo in a comment (15.86 KB, patch)
2016-08-30 15:06 PDT, Ricky Mondello 		eric.carlson: review+
Details | Formatted Diff | Diff
Incorporated Eric's review feedback. (15.95 KB, patch)
2016-08-30 16:44 PDT, Ricky Mondello 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ricky Mondello 2016-08-30 14:36:47 PDT 
YouTubePluginReplacementTest's URL transformation logic should have tests
Comment 1 Ricky Mondello 2016-08-30 14:56:54 PDT 
Created attachment 287436 [details]
First attempt at adding some tests
Comment 2 WebKit Commit Bot 2016-08-30 14:59:26 PDT 
Attachment 287436 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp:28:  Found WebCore config.h after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp:44:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2016-08-30 15:02:40 PDT 
Comment on attachment 287436 [details]
First attempt at adding some tests

View in context: https://bugs.webkit.org/attachment.cgi?id=287436&action=review

> Tools/TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp:67
> +    // Even with an extra paremeter.

Parameter.
Comment 4 Ricky Mondello 2016-08-30 15:06:48 PDT 
Created attachment 287438 [details]
Mind the style checker and fix a typo in a comment
Comment 5 Eric Carlson 2016-08-30 16:07:06 PDT 
Comment on attachment 287438 [details]
Mind the style checker and fix a typo in a comment

View in context: https://bugs.webkit.org/attachment.cgi?id=287438&action=review

> Source/WebCore/ChangeLog:5
> +        YouTubePluginReplacementTest's URL transformation logic should have tests
> +        https://bugs.webkit.org/show_bug.cgi?id=161406
> +

Nit: please include the Radar number as well.
Comment 6 Ricky Mondello 2016-08-30 16:44:51 PDT 
Created attachment 287453 [details]
Incorporated Eric's review feedback.
Comment 7 WebKit Commit Bot 2016-08-30 17:36:32 PDT 
Comment on attachment 287453 [details]
Incorporated Eric's review feedback.

Clearing flags on attachment: 287453

Committed r205212: <http://trac.webkit.org/changeset/205212>