Bug 161397 - [[Delete]] should throw for cross-origin Window / Location objects
Summary: [[Delete]] should throw for cross-origin Window / Location objects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2016-08-30 13:26 PDT by Chris Dumez
Modified: 2016-08-30 15:26 PDT (History)
6 users (show)

See Also:

Attachments
Patch (10.83 KB, patch)
2016-08-30 14:47 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-08-30 13:26:39 PDT 
[[Delete]] should throw for cross-origin Window / Location objects:
- https://github.com/whatwg/html/pull/1728

Firefox and Chrome already throw.
Comment 1 Chris Dumez 2016-08-30 14:47:11 PDT 
Created attachment 287433 [details]
Patch
Comment 2 Chris Dumez 2016-08-30 14:51:06 PDT 
Corresponding spec bug:
https://github.com/whatwg/html/issues/1726

This is because the spec would cause us to throw only in strict mode, however, Firefox / Chrome throw in non-strict mode as well.

This is being addressed via:
https://github.com/whatwg/html/pull/1728
Comment 3 WebKit Commit Bot 2016-08-30 15:26:31 PDT 
Comment on attachment 287433 [details]
Patch

Clearing flags on attachment: 287433

Committed r205200: <http://trac.webkit.org/changeset/205200>
Comment 4 WebKit Commit Bot 2016-08-30 15:26:39 PDT 
All reviewed patches have been landed.  Closing bug.