RESOLVED FIXED161386
REGRESSION (r201701): Unable to copy from CodeMirror editor version used in Jenkins install website 
https://bugs.webkit.org/show_bug.cgi?id=161386
Summary REGRESSION (r201701): Unable to copy from CodeMirror editor version used in J...
Antti Koivisto
Reported 2016-08-30 09:22:54 PDT
This depends on very specific behavior with hidden text areas.
Attachments
patch (2.33 KB, patch)
2016-08-30 09:31 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (6.39 KB, patch)
2016-08-30 09:38 PDT, Antti Koivisto 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews123 for ios-simulator-elcapitan-wk2 (5.64 MB, application/zip)
2016-08-30 10:44 PDT, Build Bot 		no flags
Details
patch (7.62 KB, patch)
2016-08-30 11:23 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2016-08-30 09:23:07 PDT
<rdar://problem/27590077>
Antti Koivisto
Comment 2 2016-08-30 09:31:18 PDT
Created attachment 287400 [details] patch
Antti Koivisto
Comment 3 2016-08-30 09:38:21 PDT
Created attachment 287402 [details] patch
Build Bot
Comment 4 2016-08-30 10:44:38 PDT
Comment on attachment 287402 [details] patch Attachment 287402 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1973903 New failing tests: editing/text-iterator/hidden-textarea-selection-quirk.html
Build Bot
Comment 5 2016-08-30 10:44:43 PDT
Created attachment 287409 [details] Archive of layout-test-results from ews123 for ios-simulator-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-elcapitan-wk2 Platform: Mac OS X 10.11.5
Antti Koivisto
Comment 6 2016-08-30 11:23:33 PDT
Created attachment 287416 [details] patch
Alexey Proskuryakov
Comment 7 2016-08-30 14:45:24 PDT
Comment on attachment 287416 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=287416&action=review > LayoutTests/platform/ios-simulator/editing/text-iterator/hidden-textarea-selection-quirk-expected.txt:9 > +FAIL Selecting in barely visible textarea assert_equals: expected "test text" but got "" > +PASS Selecting in barely visible div > +PASS Selecting in textarea hidden by container > +PASS Selecting in div hidden by container > +FAIL Selecting in absolute positioned textarea hidden by container assert_equals: expected "test text" but got "" > +PASS Selecting in absolute positioned div hidden by container > +FAIL Selecting in absolute positioned zero content width textarea hidden by container (quirk behavior) assert_equals: expected "test text" but got "" Could you please add a few words about the expected failures in the ChangeLog? Are these actually expected on iOS, or things that need to be fixed eventually?
Antti Koivisto
Comment 8 2016-08-31 01:49:12 PDT
> Could you please add a few words about the expected failures in the > ChangeLog? Are these actually expected on iOS, or things that need to be > fixed eventually? LayoutTests/ChangeLog says this: "textarea.select() doesn't select the text content on iOS."
WebKit Commit Bot
Comment 9 2016-08-31 02:14:17 PDT
Comment on attachment 287416 [details] patch Clearing flags on attachment: 287416 Committed r205246: <http://trac.webkit.org/changeset/205246>
WebKit Commit Bot
Comment 10 2016-08-31 02:14:25 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 11 2016-08-31 13:32:18 PDT
> LayoutTests/ChangeLog says this: Oh. I was fooled by a blank line between these. I guess I'm easy to mislead :)
Antti Koivisto
Comment 12 2016-08-31 15:10:11 PDT
No idea why we have this iOS behavior, it is old. I thought it's better document it rather than make a workaround in the test.
Alexey Proskuryakov
Comment 13 2016-08-31 15:16:34 PDT
Makes sense.
Note You need to log in before you can comment on or make changes to this bug.