WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
16137
Web Inspector window on Leopard should have a unified toolbar and window title
https://bugs.webkit.org/show_bug.cgi?id=16137
Summary
Web Inspector window on Leopard should have a unified toolbar and window title
Timothy Hatcher
Reported
2007-11-25 22:46:36 PST
The inspector window should have a unified title and toolbar. We can do this on Leopard.
Attachments
Picture of the change
(109.68 KB, image/png)
2007-11-25 22:48 PST
,
Timothy Hatcher
no flags
Details
Patch
(14.38 KB, patch)
2007-11-25 23:03 PST
,
Timothy Hatcher
aroben
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Timothy Hatcher
Comment 1
2007-11-25 22:48:58 PST
Created
attachment 17524
[details]
Picture of the change
Adam Roben (:aroben)
Comment 2
2007-11-25 22:51:52 PST
It would be nice to do this on Windows as well.
Adam Roben (:aroben)
Comment 3
2007-11-25 22:52:30 PST
(In reply to
comment #2
)
> It would be nice to do this on Windows as well.
...but we'd need transparent WebView support first.
Timothy Hatcher
Comment 4
2007-11-25 23:03:34 PST
Created
attachment 17526
[details]
Patch I will update libWebKitSystemInterfaceLeopard.a and libWebKitSystemInterfaceTiger.a when I land this.
Timothy Hatcher
Comment 5
2007-11-25 23:04:59 PST
I agree, it should be done on Windows too. Windows should use a metal window also.
Adam Roben (:aroben)
Comment 6
2007-11-25 23:13:51 PST
Comment on
attachment 17526
[details]
Patch +#if PLATFORM(MAC) +#ifdef BUILDING_ON_TIGER + String platform = "mac-tiger"; +#else + String platform = "mac-leopard"; +#endif +#elif PLATFORM(WIN_OS) + String platform = "windows"; +#elif PLATFORM(QT) + String platform = "qt"; +#elif PLATFORM(GTK) + String platform = "gtk"; +#elif PLATFORM(WX) + String platform = "wx"; +#else + String platform = "unknown"; +#endif You should make these static const Strings. + JSStringRef platformString = JSStringCreateWithCharacters(platform.characters(), platform.length()); You should put this in a JSRetainPtr. + Add a new class to make window corners square for textured windows. Typo: class -> function +void WKNSWindowSquareBottomCorners(NSWindow *); It would be nice to get a verb in there somewhere (using "square" as a verb isn't terribly clear). Maybe WKNSWindowMakeBottomCornersSquare? r=me
Timothy Hatcher
Comment 7
2007-11-26 09:18:43 PST
Landed in
r28039
.
http://trac.webkit.org/projects/webkit/changeset/28039
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug